Handle cases where a graphfunction has removed all potential pipe carrying edges #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
added 4 commits
June 13, 2024 14:14
Return the empty graph so that it can be detected by swmmanywhere
dalonsoa
approved these changes
Jun 19, 2024
|
Yep it's still a valid graph - but not a valid sewer model - so if I try write this and simulate it in SWMM it will crash. A graph could end up with no edges, for example, if all of the nodes are within |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It is possible a graph function could result in a graph with no edges - at which point
iterate_graphfcnscannot proceed. Since I am often callingswmmanywherein a single script - it is preferrable that this doesn't simply crash out. This PR handles and tests thatFixes #216