Create two shortest path options in own module #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalonsoa
approved these changes
May 24, 2024
| while in_edge_pq: | ||
| weight, u, v = heapq.heappop(in_edge_pq) | ||
|
|
||
| if u not in parent: |
There was a problem hiding this comment.
To avoid too much indentation, you can check the opposite and then continue:
if u in parent:
continue
# If v is not in the MST yet, add the edge (u, v) to the MST
parent[u] = v
...Visually, it reduces complexity.
Comment on lines
+75
to
+76
| # Check if all vertices are reachable from the root | ||
| if len(parent) != n - 1: |
There was a problem hiding this comment.
I don't follow this. Why checking the length checks that all vertices are reachable from the root? I mean, why such a length should be equal to n-1, when n is the total number of nodes? Probably is because I do not fully understand what these trees are, so don't worry if it's obvious it should this like this.
| mst_edges = [] | ||
| mst_weight = 0 | ||
| outlets: dict = {} | ||
| while in_edge_pq: |
There was a problem hiding this comment.
Maybe add a top level explanation of what this loop is doing and how ti finds the MST.
| for path in paths.values(): | ||
| # Assign outlet | ||
| outlet = path[0] | ||
| for node in path: |
There was a problem hiding this comment.
Should this exclude path[0] or that one should have as outlet itself?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A lot of changes in #144 so I am splitting out what I can to be reviewed separately.
In this PR I have written and tested two shortest path functions for deriving network topology.
These are currently standalone and will be incorporated into
graph_utilities.py\derive_topologyin a separate PR.