Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ci.yml #164

Merged
merged 12 commits into from
May 15, 2024
Merged

Update ci.yml #164

merged 12 commits into from
May 15, 2024

Conversation

barneydobson
Copy link
Collaborator

@barneydobson barneydobson commented May 15, 2024

use ubuntu unless merging. @dalonsoa hopefully I'll not be in any more trouble about this ;)

@barneydobson barneydobson requested review from dalonsoa and removed request for dalonsoa May 15, 2024 09:35
@barneydobson barneydobson requested a review from dalonsoa May 15, 2024 09:41
Copy link
Collaborator

@dalonsoa dalonsoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. And don't worry too much. It has happened to us in the past. We need to be careful, but it is not the end of the world.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
Dobson added 2 commits May 15, 2024 11:42
use doc recommended method
@barneydobson barneydobson merged commit ef3a24d into main May 15, 2024
10 checks passed
@barneydobson barneydobson deleted the workflow_overhead branch May 15, 2024 11:18
@barneydobson barneydobson restored the workflow_overhead branch May 15, 2024 11:19
@barneydobson
Copy link
Collaborator Author

Tried a bunch of things and couldn't get it to work on merge... nevermind, poor macos users

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants