Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce double directed to improve network cleanup #142

Merged
merged 15 commits into from
May 3, 2024

Conversation

barneydobson
Copy link
Collaborator

@barneydobson barneydobson commented Apr 28, 2024

Description

Fixes #42 #39

Summary:

  • Add streetcover to shapefile generation
  • Add to_undirected
  • Refactor split_long_edges (enabled by to_undirected)
  • Add merge_nodes
  • Move double_directed to immediately before slope calculation (i.e., the only part it is needed)

@barneydobson barneydobson linked an issue Apr 28, 2024 that may be closed by this pull request
swmmanywhere/graph_utilities.py Outdated Show resolved Hide resolved
swmmanywhere/graph_utilities.py Outdated Show resolved Hide resolved
swmmanywhere/graph_utilities.py Outdated Show resolved Hide resolved
swmmanywhere/graph_utilities.py Outdated Show resolved Hide resolved
swmmanywhere/graph_utilities.py Show resolved Hide resolved
vectorise some operations
Copy link
Collaborator

@dalonsoa dalonsoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! No big comments from my side, besides @cheginit observations, whose implications I don't really understand.

swmmanywhere/graph_utilities.py Outdated Show resolved Hide resolved
@barneydobson barneydobson merged commit 6e6c326 into main May 3, 2024
7 of 10 checks passed
@barneydobson barneydobson deleted the un_double_directed branch May 3, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use an undirected approach rather than double directed
3 participants