Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More logging #116

Merged
merged 20 commits into from
May 28, 2024
Merged

More logging #116

merged 20 commits into from
May 28, 2024

Conversation

barneydobson
Copy link
Collaborator

@barneydobson barneydobson commented Mar 27, 2024

Description

  • Remove all the chaff in post_processing/synthetic_write (currently just commented - as this may be useful for the eventual refactor in SWMM file writing #16 )
  • Link tqdm to verbosity, and maybe the simulation can be tqdmed?
  • Print out information about the model (number, bbox, etc)
  • When does simulation start/finish
  • Things like 'starting iterate_graphfcns' and 'starting iterate_metrics'
  • Progress bar for simulation
  • Break down logging in larger functions so the bottleneck can be identified (i.e., subcatch calcs) (too excessive for now, especially since pyflwdir massively speeds things up..)
  • Maybe an intermediate toggle for things like (e.g.,) printing the graph after each graphfcn (not sure is necessary at this stage)
  • I have made a lot of the logger.info/etc inside a check of verbosity is true... this obviously isn't needed since that is handled in the logger.
  • Save config file used to model dir
  • Add and test parameter validation (... not quite logging.. but... similar?)

Fixes #71

@barneydobson barneydobson linked an issue Mar 27, 2024 that may be closed by this pull request
5 tasks
@barneydobson barneydobson requested review from dalonsoa and cheginit May 23, 2024 14:13
@barneydobson barneydobson mentioned this pull request May 23, 2024
5 tasks
Copy link
Collaborator

@cheginit cheginit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a couple of comments, the rest looks good to me.

swmmanywhere/logging.py Outdated Show resolved Hide resolved
swmmanywhere/logging.py Outdated Show resolved Hide resolved
swmmanywhere/swmmanywhere.py Outdated Show resolved Hide resolved
swmmanywhere/swmmanywhere.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@dalonsoa dalonsoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving this as my comments are mostly agreeing with @cheginit ones, so will be fixed at the same time. The custom tqdm definitely needs a review.

swmmanywhere/post_processing.py Outdated Show resolved Hide resolved
don't check categories for every override item
use `auto`
- Add utilities for yaml
- Remove custom tqdm
- Add verbosity variable
@barneydobson barneydobson merged commit 78b039b into main May 28, 2024
4 checks passed
@barneydobson barneydobson deleted the more_logging branch May 28, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

More comprehensive logging messages
3 participants