-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More logging #116
More logging #116
Conversation
logger already checks verbosity
print more info
improve docstring
check_parameter_overrides
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a couple of comments, the rest looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm approving this as my comments are mostly agreeing with @cheginit ones, so will be fixed at the same time. The custom tqdm
definitely needs a review.
don't check categories for every override item
use `auto`
move to correct pos
Description
post_processing/synthetic_write
(currently just commented - as this may be useful for the eventual refactor in SWMM file writing #16 )tqdm
to verbosity, and maybe the simulation can be tqdmed?Break down logging in larger functions so the bottleneck can be identified (i.e., subcatch calcs)(too excessive for now, especially sincepyflwdir
massively speeds things up..)Maybe an intermediate toggle for things like (e.g.,) printing the graph after each(not sure is necessary at this stage)graphfcn
config
file used tomodel
dirFixes #71