-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Repo structure #107
Repo structure #107
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Conda/Mamba does not support pyproject.toml
. You will need write an environment file for that (or more than one for normal users and developers).
I've just come across Pixi. I've never tried to use it but I know they are working on implementing support for pyroject.toml
. Might be worth to have a look from time to time.
CONTRIBUTING.md
Outdated
We use [`pip-tools`](https://pip-tools.readthedocs.io/en/latest/) to ensure | ||
consistency in the development process, ensuring all people contributing to | ||
`SWMManywhere` uses the same versions for all the dependencies, which minimiese | ||
the conflicts. To install the development dependencies and then `SWMManywhere` | ||
in development mode run: | ||
|
||
```bash | ||
pip install -r requirements-dev.txt | ||
pip install -e . | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why you started out with conda
then switched to pip
?
Regardless, I think using micromamba
makes things much more straightforward. Installation is very easy and is much, much faster than using conda
since it's based on mamba
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been using the pyproject.toml
- which I think conda/mamba
doesn't use? Does it make sense to just discuss this as part of #113 ? Or is it different?
@barneydobson @dalonsoa I've used My current workflow is using micromamba env create -f ci/requirements/environment-dev.yml
micromamba activate env_name Then, testing, linting, and type checking becomes just running: nox |
Sounds good - referenced in issue #113 |
Merging this as any of the leftovers can be discussed in #113 |
Description
I've mainly just repurposed what was used in WSIMOD.
conda
by default - see quote below? Though the testing has been fine so far and it tests on ubuntu, macos and windows. Is there a simple way to implement this that is also compatible with thepyproject.toml
installation?From #24 by @cheginit
Fixes #24