Update metric_utilities.py

use comprehension
ImperialCollegeLondon · Mar 19, 2024 · 2afaa3a · 2afaa3a
1 parent f1d89af
commit 2afaa3a
Showing 1 changed file with 7 additions and 9 deletions.
diff --git a/swmmanywhere/metric_utilities.py b/swmmanywhere/metric_utilities.py
@@ -369,15 +369,13 @@ def create_grid(bbox: tuple,
     dy = scale
     minx, miny, maxx, maxy = bbox
 
-    grid = []
-    for i in range(int((maxx - minx) // dx + 1)):
-        for j in range(int((maxy - miny) // dy + 1)):
-            grid.append({'geometry' : shapely.Polygon([(minx + i * dx, 
-                                                        miny + j * dy),
-                                 (minx + (i + 1) * dx, miny + j * dy),
-                                 (minx + (i + 1) * dx, miny + (j + 1) * dy),
-                                 (minx + i * dx, miny + (j + 1) * dy)]),
-                         'sub_id' : f'{i}_{j}'})
+    grid = [{'geometry': shapely.geometry.Polygon([(minx + i * dx, miny + j * dy),
+                                        (minx + (i + 1) * dx, miny + j * dy),
+                                        (minx + (i + 1) * dx, miny + (j + 1) * dy),
+                                        (minx + i * dx, miny + (j + 1) * dy)]),
+         'sub_id': f'{i}_{j}'}
+        for i in range(int((maxx - minx) // dx + 1))
+        for j in range(int((maxy - miny) // dy + 1))]
     return gpd.GeoDataFrame(grid)
 
 @metrics.register