pallet-dispute #194
Merged
pallet-dispute #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshankarrao
force-pushed
the
pallet-dispute
branch
from
b443685
to
9eb97a1
Compare
samelamin
reviewed
Oct 5, 2023
samelamin
reviewed
Oct 5, 2023
samelamin
reviewed
Oct 5, 2023
| return DisputeResult::Failure; | ||
| } | ||
|
|
||
| if self.votes.values().filter(|&&x| x).count() |
There was a problem hiding this comment.
what happens if only 1 member in the dispute?
There was a problem hiding this comment.
also instead of X, can we use is_yay or something similar?
samelamin
approved these changes
Oct 5, 2023
|
LGTM once build passes |
mshankarrao
force-pushed
the
pallet-dispute
branch
from
e951209
to
4890b04
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #131