Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update front page links to open specific series #311

Closed
fedorov opened this issue Sep 18, 2020 · 3 comments
Closed

Update front page links to open specific series #311

fedorov opened this issue Sep 18, 2020 · 3 comments
Assignees
Labels
enhancement New feature or request explore page merged:dev Merged into the developement tier MVP testing needed Functionality is available in idc-dev for testing testing passed Functionality works as expected on the testing tier

Comments

@fedorov
Copy link
Member

fedorov commented Sep 18, 2020

@s-paquette would it be very difficult to update the URLs to add the following suffixes to select the specific series we show in the thumbnails?

CT: /?seriesInstanceUID=1.2.276.0.7230010.3.1.3.0.57823.1553343864.578877,1.3.6.1.4.1.14519.5.2.1.6279.6001.273525289046256012743471155680
MR: /?seriesInstanceUID=1.3.6.1.4.1.14519.5.2.1.1706.4001.315980779833795710131738723922
PET: /?seriesInstanceUID=1.3.6.1.4.1.14519.5.2.1.2744.7002.746890305525203600008140092112,1.3.6.1.4.1.14519.5.2.1.2744.7002.304930022156956249911027532702

@fedorov fedorov added enhancement New feature or request explore page triage needed Ticket needs to be reviewed by the developers and assigned to the proper milestone labels Sep 18, 2020
@fedorov fedorov added the MVP label Sep 21, 2020
@wlongabaugh
Copy link
Member

So the viewer in dev and test can now handle these URLs, so we can add them right now. The suffixes above glue directly onto the existing URLs, e.g. the existing DICOM ID stays in the URL, with the /?seriesInstanceUID= glued on. I see that the existing URLs (e.g. search '1.3.6.1.4.1.14519.5.2.1.6279.6001.224985459390356936417021464571') show up in IDC-WebApp/idc/views.py and in IDC-WebApp/templates/idc/landing.html. Not sure where I see the tooltips specified in views.py showing up? I figure that @mitianisb can do this instead of @s-paquette. Ideally, long-term these should be specified in the env file, a config file, or DB table.

@mitianisb
Copy link

@wlongabaugh I have updated the links. It is in a PR with some other ticket's changes. I can also change them to be from env file after MVP.

@wlongabaugh
Copy link
Member

wlongabaugh commented Sep 22, 2020 via email

@mitianisb mitianisb added the testing needed Functionality is available in idc-dev for testing label Sep 22, 2020
@s-paquette s-paquette added merged:dev Merged into the developement tier and removed triage needed Ticket needs to be reviewed by the developers and assigned to the proper milestone labels Sep 22, 2020
@madelyngreyes madelyngreyes added the testing passed Functionality works as expected on the testing tier label Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request explore page merged:dev Merged into the developement tier MVP testing needed Functionality is available in idc-dev for testing testing passed Functionality works as expected on the testing tier
Projects
None yet
Development

No branches or pull requests

5 participants