Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not throw 500 when no votes found #43

Open
lukasotocerny opened this issue Mar 7, 2021 · 1 comment
Open

Do not throw 500 when no votes found #43

lukasotocerny opened this issue Mar 7, 2021 · 1 comment
Labels
invalid This doesn't seem right

Comments

@lukasotocerny
Copy link
Member

Currently the endpoint /users/{user-id}/votes returns HTTP 500 from method getAllVotesForUser. That's not a good practice and should either return HTTP 200 [] empty array, or HTTP 404.
@lukasotocerny lukasotocerny added the invalid This doesn't seem right label Mar 7, 2021
@DerrickGXD
Copy link
Contributor

New pull request has changed the error handling from InternalServerErrorException to NotFoundException, so it should be returning HTTP 404 now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lukasotocerny @DerrickGXD