Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nuke live scene #1310

Merged
merged 9 commits into from
Nov 3, 2022
Merged

Nuke live scene #1310

merged 9 commits into from
Nov 3, 2022

Conversation

lucienfostier
Copy link
Contributor

@lucienfostier lucienfostier commented Nov 3, 2022 •
edited
Loading

Features

  • Add LiveScene support for Nuke (Nuke live scene #1310)
    • LiveSceneKnob: Knob to interface with LiveScene from Python
    • LiveSceneHolder: Node to hold LiveSceneKnob to provide a Python interface with LiveScene.

Related Issues

  • List any Issues this PR addresses or solves

Dependencies

  • List any other unmerged PRs that this PR depends on

Breaking Changes

  • List any breaking API/ABI changes

Checklist

  • I have read the contribution guidelines.
  • I have updated the documentation, if applicable.
  • I have tested my change(s) in the test suite, and added new test cases where necessary.
  • My code follows the Cortex project's prevailing coding style and conventions.

@lucienfostier
Convert: Added conversion from DD::Image::Box3 to Imath::Box3f and Im…
49720a5 
…ath::Box3d and Imath::M44d to DD::Image::Matrix4.
@lucienfostier
SceneCacheReader: Stop transforming the mesh into world space.
b05cd3b 
We want to maintain the world space matrix instead of transforming the points
so we can more easily round trip scene cache in/out of nuke.
This allows to write the bounds as the SceneInterface expects ( local space ).

Due to some kind of reset happening in the SourceGeo source code, we need to store
the matrix in create_geometry and apply in the geometry_engine.

I think this should work fine considering that Op are instantiate per output context ( frame )
so we shouldn't have a clash in the map data structure.
@lucienfostier
LiveScene: Implementation of LiveScene for Nuke.
6369d9b 
Allow to query the Nuke's scene representation through the SceneInterface API.
@lucienfostier
SceneCacheReader: Add path attribute in geometry converter so we can …
26d6000 
…round trip hierarchy.
@lucienfostier
LiveSceneKnob: A knob to query the incoming 3d scene using the SceneI…
06dc99c 
…nterface
@lucienfostier
LiveSceneHolder: Node to hold a LiveSceneKnob to query the input scen…
49eca0f 
…e as a cortex SceneInterface
@lucienfostier
LiveSceneKnobTest: Added test for LiveSceneKnob and LiveSceneHolder node
ef7a09a
@lucienfostier
SceneCacheWriter: Plugin for nuke WriteGeo to write SceneCache file
121ccf1
@lucienfostier
SceneCacheWriterTest: Test for SceneCacheWriter plugin.
b56b9b8
@ivanimanishi ivanimanishi merged commit 20c5800 into ImageEngine:RB-10.3 Nov 3, 2022
ivanimanishi added a commit that referenced this pull request Nov 3, 2022
@ivanimanishi
Changes : Updated for PR #1310
b6182a1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivanimanishi ivanimanishi ivanimanishi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucienfostier @ivanimanishi