Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use non-boxing forall and exists methods on strings #154

Merged
merged 2 commits into from
Jul 9, 2023
Merged

Use non-boxing forall and exists methods on strings #154

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
98a4a4d
Use non-boxing `forall` strings
kyri-petrou Jul 9, 2023
b73823a
Implement optimized `exists`
kyri-petrou Jul 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 28 additions & 4 deletions main/src/io/github/iltotore/iron/constraint/collection.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ object collection:
.map(applyConstraint(_, constraintExpr))
.foldLeft(Expr(true))((e, t) => '{ $e && $t })

case None => '{ $expr.forall(c => ${ applyConstraint('c, constraintExpr) }) }
case None => '{ $expr.forallOptimized(c => ${ applyConstraint('c, constraintExpr) }) }

given [C1, C2](using C1 ==> C2): (ForAll[C1] ==> Exists[C2]) = Implication()
given [C1, C2](using C1 ==> C2): (ForAll[C1] ==> Last[C2]) = Implication()
Expand Down Expand Up @@ -207,7 +207,7 @@ object collection:
.map(applyConstraint(_, constraintExpr))
.foldLeft(Expr(true))((e, t) => '{ $e && $t })

case None => '{ $expr.init.forall(c => ${ applyConstraint('c, constraintExpr) }) }
case None => '{ $expr.init.forallOptimized(c => ${ applyConstraint('c, constraintExpr) }) }

given [C1, C2](using C1 ==> C2): (Init[C1] ==> Exists[C2]) = Implication()

Expand Down Expand Up @@ -244,7 +244,7 @@ object collection:
.map(applyConstraint(_, constraintExpr))
.foldLeft(Expr(true))((e, t) => '{ $e && $t })

case None => '{ $expr.tail.forall(c => ${ applyConstraint('c, constraintExpr) }) }
case None => '{ $expr.tail.forallOptimized(c => ${ applyConstraint('c, constraintExpr) }) }

given [C1, C2](using C1 ==> C2): (Tail[C1] ==> Exists[C2]) = Implication()
given [C1, C2](using C1 ==> C2): (Tail[C1] ==> Last[C2]) = Implication()
Expand Down Expand Up @@ -279,7 +279,7 @@ object collection:
.map(applyConstraint(_, constraintExpr))
.foldLeft(Expr(false))((e, t) => '{ $e || $t })

case None => '{ $expr.exists(c => ${ applyConstraint('c, constraintExpr) }) }
case None => '{ $expr.existsOptimized(c => ${ applyConstraint('c, constraintExpr) }) }

object Head:

Expand Down Expand Up @@ -338,3 +338,27 @@ object collection:
case None => '{ $expr.lastOption.exists(last => ${ applyConstraint('{ last }, constraintExpr) }) }

given [C1, C2](using C1 ==> C2): (Last[C1] ==> Exists[C2]) = Implication()

/**
* Scala's [[Function1]] doesn't have a specialization on [[Char]] arguments, which causes each char in the string to be boxed
* when calling `forall`. This trait is used as a substitute to avoid this issue.
*/
private trait EvalChar:
def apply(value: Char): Boolean

extension (s: String)
private def forallOptimized(p: EvalChar): Boolean =
var i = 0
val len = s.length
while i < len do
if !p(s.charAt(i)) then return false
i += 1
true

private def existsOptimized(p: EvalChar): Boolean =
var i = 0
val len = s.length
while i < len do
if p(s.charAt(i)) then return true
i += 1
false