[pull] main from pydata:main #608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
* Optimize idxmin, idxmax with dask Closes #9425 * use map_blocks instead * small edits * fix typing * try again * Migrate to DaskIndexingAdapter * cleanup * fix? * finish * fix types * review comments
* cache array keys on ZarrStore instances * refactor get_array_keys * add test for get_array_keys * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * lint * add type annotation for _cache * make type hint accurate * make type hint pass mypy * make type hint pass mypy, correctly * Update xarray/backends/zarr.py Co-authored-by: Deepak Cherian <[email protected]> * use roundtrip method instead of explicit alternative * cache members instead of just array keys * adjust test to members caching * refactor members cache * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * explictly revert changes to test_write_store * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * indent correctly * update instrumented tests, remove cache update functionality, and set cache default to False in test fixtures * update instrumented tests, remove cache update functionality, and set cache default to False in test fixtures * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * lint * update tests * make check_requests more permissive * update instrumented tests for zarr==2.18 * Update xarray/backends/zarr.py Co-authored-by: Deepak Cherian <[email protected]> * Update xarray/backends/zarr.py Co-authored-by: Deepak Cherian <[email protected]> * Update xarray/backends/zarr.py Co-authored-by: Deepak Cherian <[email protected]> * Update xarray/backends/zarr.py Co-authored-by: Deepak Cherian <[email protected]> * Update xarray/backends/zarr.py Co-authored-by: Deepak Cherian <[email protected]> * doc: add whats new content * fixup * update whats new * fixup * remove vestigial cache_array_keys * make cache_members default to True * tweak * Remove from public API --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Deepak Cherian <[email protected]> Co-authored-by: Deepak Cherian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )