Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] main from pydata:main #519

Merged
merged 3 commits into from
Sep 24, 2023
Merged

[pull] main from pydata:main #519

merged 3 commits into from
Sep 24, 2023

Conversation

pull[bot]
Copy link

@pull pull bot commented Sep 24, 2023

See Commits and Changes for more details.


Created by pull[bot]

Can you help keep this open source service alive? 💖 Please sponsor : )

Illviljan and others added 3 commits September 24, 2023 16:03
* Update dataset.py

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* more typing

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update xarray/core/dataset.py

Co-authored-by: Michael Niklas  <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Michael Niklas <[email protected]>
…eger dtype (#8201)

* remove `dtype` from encoding for datetime64/timedelta64 variables to prevent unnecessary casts

* adapt tests

* add whats-new.rst entry

* Update xarray/coding/times.py

Co-authored-by: Spencer Clark <[email protected]>

* Update doc/whats-new.rst

Co-authored-by: Spencer Clark <[email protected]>

* add test per review suggestion, replace .kind-check with np.issubdtype-check

* align timedelta64 check with datetime64 check

* override units instead of dtype

* remove print statement

* warn in case of serialization to floating point, too

* align if-else

* Add instructions to warnings

* Fix test

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* use warnings.catch_warnings

* Update doc/whats-new.rst

Co-authored-by: Spencer Clark <[email protected]>

---------

Co-authored-by: Spencer Clark <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* ENH: test_interpolate_pd_compat with range of fill_value's
* add whats-new.rst entry
@pull pull bot merged commit 05b3a21 into Illviljan:main Sep 24, 2023
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants