Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ttonev/excel style editing #605

Merged
merged 15 commits into from
Oct 7, 2024
Merged

Ttonev/excel style editing #605

merged 15 commits into from
Oct 7, 2024

Conversation

tishko0
Copy link
Contributor

@tishko0 tishko0 commented Jul 23, 2024

No description provided.

@tishko0 tishko0 requested a review from MayaKirova July 23, 2024 12:28
@tishko0 tishko0 marked this pull request as ready for review July 23, 2024 12:28
@MarielaTihova
Copy link
Contributor

Found 2 issues in the behaviour of this sample:

  1. Unable to type numbers from the side numbers keyboard (numpad) when clicking only ONCE on the cell. When we double click everything is ok.

Steps to reproduce:

  1. Click ONCE on a cell
  2. Type numbers from the side numbers keyboard (numpad)
  3. Observe how numbers are not being entered in that cell
  4. Doble click -> we are able to enter numbers from that side numbers keyboard
  1. Unable to move to the next row (the cell under the current one) by clicking on "Enter". We have to click TWICE for that to happen. Inconsistent behaviour with other platforms.

Steps to reproduce:

  1. Edit the content of some cell
  2. Click on "Enter"

Expected result: After clicking on "Enter" we should be positioned on the cell under the current one
Actual result: After clicking on "Enter" the cell on focused is the same one we edited. We have to click twice to go on the cell under the current one

@MarielaTihova MarielaTihova added the status: in-development PR is not finished label Aug 16, 2024
@MarielaTihova
Copy link
Contributor

MarielaTihova commented Aug 21, 2024

Retested after commits from 20.08

  • Issue 1: Resolved
  • Issue 2: Persists

@MarielaTihova MarielaTihova added status: verified The PR is tested and ready for a merge and removed status: in-development PR is not finished labels Oct 4, 2024
@dkamburov dkamburov merged commit 2f38a58 into vnext Oct 7, 2024
2 checks passed
@dkamburov dkamburov deleted the ttonev/excel-style-editing branch October 7, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: verified The PR is tested and ready for a merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants