Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added grid and hgrid remote paging samples #557

Merged
merged 11 commits into from
Oct 11, 2024

Conversation

tishko0
Copy link
Contributor

@tishko0 tishko0 commented May 21, 2024

No description provided.

@MarielaTihova MarielaTihova self-assigned this Aug 16, 2024
@MarielaTihova MarielaTihova added the status: in-development PR is not finished label Aug 21, 2024
@MarielaTihova
Copy link
Contributor

MarielaTihova commented Sep 10, 2024

Issue 1: for HGrid:

HGgrid- Remote paging- console error

@MarielaTihova
Copy link
Contributor

MarielaTihova commented Sep 10, 2024

Issue 2: for Grid:
( * ) Paging is NOT working for remote-paging-data example.
(**) Paging is working for remote-paging-grid example.
@tishko0 What is the relation between these two? Changes in this PR seem to be only for remote-paging-grid. Should we create a separate issue for ( * ) or is it something that is obsolete?

Ggrid- Remote paging- paging not working

@MarielaTihova
Copy link
Contributor

Issue 3: for both Grid and HGrid

When routing to remote paging sample from any other sample, these console errors appear:

image

Steps to reproduce:

  1. Run all samples (browser folder)
  2. Go to some random sample URL, for example http://localhost:4200/react-demos/samples/grids/hierarchical-grid/multi-column-headers-template
  3. The go to the Remote paging sample URL: http://localhost:4200/react-demos/samples/grids/hierarchical-grid/remote-paging-hgrid

@MarielaTihova
Copy link
Contributor

Issue 2: for Grid: ( * ) Paging is NOT working for remote-paging-data example. (**) Paging is working for remote-paging-grid example. @tishko0 What is the relation between these two? Changes in this PR seem to be only for remote-paging-grid. Should we create a separate issue for ( * ) or is it something that is obsolete?

Ggrid- Remote paging- paging not working

Issue 2 -> RESOLVED

@MarielaTihova
Copy link
Contributor

Issue 3: for both Grid and HGrid

When routing to remote paging sample from any other sample, these console errors appear:

image Steps to reproduce:
  1. Run all samples (browser folder)
  2. Go to some random sample URL, for example http://localhost:4200/react-demos/samples/grids/hierarchical-grid/multi-column-headers-template
  3. The go to the Remote paging sample URL: http://localhost:4200/react-demos/samples/grids/hierarchical-grid/remote-paging-hgrid

Issue 3 persists. @tishko0 can you please have a look at it?

@tishko0
Copy link
Contributor Author

tishko0 commented Sep 24, 2024

Issue 3: for both Grid and HGrid
When routing to remote paging sample from any other sample, these console errors appear:
image
Steps to reproduce:

  1. Run all samples (browser folder)
  2. Go to some random sample URL, for example http://localhost:4200/react-demos/samples/grids/hierarchical-grid/multi-column-headers-template
  3. The go to the Remote paging sample URL: http://localhost:4200/react-demos/samples/grids/hierarchical-grid/remote-paging-hgrid

Issue 3 persists. @tishko0 can you please have a look at it?

removed errors ^^

@MarielaTihova MarielaTihova added status: verified The PR is tested and ready for a merge and removed status: in-development PR is not finished labels Sep 25, 2024
@dkamburov
Copy link
Contributor

@tishko0 there is a merge conflict

Copy link
Collaborator

@HUSSAR-mtrela HUSSAR-mtrela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you remove NwindData.ts and index.tsx files in
samples/grids/grid/remote-paging-data sample?

@dkamburov
Copy link
Contributor

Why did you remove NwindData.ts and index.tsx files in samples/grids/grid/remote-paging-data sample?

This is an old sample and it's not referenced nowhere, it's basically being removed in favor of the new one.

@dkamburov dkamburov merged commit 1112739 into vnext Oct 11, 2024
2 checks passed
@dkamburov dkamburov deleted the ttonev/remote-paging-samples branch October 11, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: verified The PR is tested and ready for a merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants