Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(grid): update row selection renamed event #3020

Merged
merged 1 commit into from
Nov 16, 2021

Conversation

damyanpetev
Copy link
Member

Rename Row Selection even according to change from IgniteUI/igniteui-angular#10493

Checklist:

  • check topic's TOC/menu and paragraph headings
  • link to other topics using ../relative/path.md
  • at the References section at the end of the topic add links to topics, samples, etc
  • reference API documentation instead of adding a section with API

  • use valid component names - [Data] Grid, IgxSelectComponent, <igx-combo>
  • use spell checker tool (VS Code, Grammarly, Microsoft Editor)
  • add inline code blocks for the names of classes / tags / properties
  • add language descriptor for the code blocks
  • check broken links (use browser add-on)
  • check if sample is working and fully visible in the topic
  • check if sample is working and fully visible in the StackBlitz
  • check if code blocks match the code in StackBlitz demo


  • do not resolve requested changes (leave that to the reviewer)
  • add pending-localization label when the review of the PR is done
  • add a member from the localization team to translate it

@ChronosSF ChronosSF requested a review from randriova November 16, 2021 11:21
@ChronosSF ChronosSF merged commit 51ad0ba into vNext Nov 16, 2021
@ChronosSF ChronosSF deleted the dpetev/grid-selection-event branch November 16, 2021 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants