Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Splitter(Docs): Add splitter topic #1876

Merged
merged 19 commits into from
Apr 28, 2020
Merged

Splitter(Docs): Add splitter topic #1876

merged 19 commits into from
Apr 28, 2020

Conversation

VMihalkov
Copy link

Closes #1842

Pending before this can be finalized:

  1. A sample with vertical splitter bar and 2 panes, e.g. a design surface and its corresponding code view
  2. A sample with more complex layout including horizonal, vertical and nested splitters

en/components/splitter.md Outdated Show resolved Hide resolved
en/components/splitter.md Outdated Show resolved Hide resolved
en/components/splitter.md Outdated Show resolved Hide resolved
en/components/splitter.md Outdated Show resolved Hide resolved
MayaKirova
MayaKirova previously approved these changes Apr 16, 2020
en/components/splitter.md Outdated Show resolved Hide resolved
en/components/splitter.md Outdated Show resolved Hide resolved
en/components/splitter.md Outdated Show resolved Hide resolved
en/components/splitter.md Outdated Show resolved Hide resolved
en/components/splitter.md Outdated Show resolved Hide resolved
en/components/splitter.md Outdated Show resolved Hide resolved
en/components/splitter.md Outdated Show resolved Hide resolved
en/components/splitter.md Outdated Show resolved Hide resolved
en/components/splitter.md Outdated Show resolved Hide resolved
jp/components/splitter.md Show resolved Hide resolved
ChronosSF
ChronosSF previously approved these changes Apr 22, 2020
@StefanIvanov
Copy link
Contributor

I made a commit with a few minor suggestions, overall the topic structure looks excellent, are we going to add styling section (I know there is not much to be styled) and an advanced section with more elaborate sample e.g. a UI/code view for example? @simeonoff @ChronosSF

@simeonoff simeonoff linked an issue Apr 22, 2020 that may be closed by this pull request
Copy link
Collaborator

@simeonoff simeonoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no styling section in this topic.

As for the samples. We could use 3 samples. All 3 samples can simply be splitting text paragraphs. The first sample could be a very simple horizontal splitter (as you have it described). The second would be a representation of the more complex splitter mentioned in the topic, again, splitting paragraphs of text. The third sample should showcase the custom theme and be a part of the missing styling section. If you have a working branch with samples, please push it, I can handle the rest.

en/components/splitter.md Show resolved Hide resolved
en/components/splitter.md Outdated Show resolved Hide resolved
@VMihalkov
Copy link
Author

There's no styling section in this topic.

As for the samples. We could use 3 samples. All 3 samples can simply be splitting text paragraphs. The first sample could be a very simple horizontal splitter (as you have it described). The second would be a representation of the more complex splitter mentioned in the topic, again, splitting paragraphs of text. The third sample should showcase the custom theme and be a part of the missing styling section. If you have a working branch with samples, please push it, I can handle the rest.

@simeonoff the 3 samples have been addded in branch vmihalkov/splitter-samples

simeonoff
simeonoff previously approved these changes Apr 24, 2020
ChronosSF
ChronosSF previously approved these changes Apr 27, 2020
@simeonoff simeonoff dismissed stale reviews from ChronosSF and themself via d33bd2d April 28, 2020 07:32
@simeonoff simeonoff self-requested a review April 28, 2020 07:42
@ChronosSF ChronosSF merged commit c6c0564 into vNext Apr 28, 2020
@ChronosSF ChronosSF deleted the vmihalkov/splitter-doc branch April 28, 2020 12:19
randriova added a commit that referenced this pull request May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Splitter Topic
6 participants