-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Splitter(Docs): Add splitter topic #1876
Conversation
I made a commit with a few minor suggestions, overall the topic structure looks excellent, are we going to add styling section (I know there is not much to be styled) and an advanced section with more elaborate sample e.g. a UI/code view for example? @simeonoff @ChronosSF |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's no styling section in this topic.
As for the samples. We could use 3 samples. All 3 samples can simply be splitting text paragraphs. The first sample could be a very simple horizontal splitter (as you have it described). The second would be a representation of the more complex splitter mentioned in the topic, again, splitting paragraphs of text. The third sample should showcase the custom theme and be a part of the missing styling section. If you have a working branch with samples, please push it, I can handle the rest.
@simeonoff the 3 samples have been addded in branch vmihalkov/splitter-samples |
Closes #1842
Pending before this can be finalized: