Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial date time editor topic #1852

Merged
merged 15 commits into from
Apr 24, 2020
Merged

Add initial date time editor topic #1852

merged 15 commits into from
Apr 24, 2020

Conversation

IvayloG
Copy link
Contributor

@IvayloG IvayloG commented Mar 27, 2020

Closes #1823

Checklist:

  • check topic's TOC/menu and paragraph headings
  • link to other topics using ../relative/path.md
  • at the References section at the end of the topic add links to topics, samples, etc
  • reference API documentation instead of adding a section with API

  • use valid component names - [Data] Grid, IgxSelectComponent, <igx-combo>
  • use spell checker tool (VS Code, Grammarly, Microsoft Editor)
  • add inline code blocks for the names of classes / tags / properties
  • add language descriptor for the code blocks
  • check broken links (use browser add-on)
  • check if sample is working and fully visible in the topic
  • check if sample is working and fully visible in the StackBlitz
  • check if code blocks match the code in StackBlitz demo


  • do not resolve requested changes (leave that to the reviewer)
  • add pending-localization label when the review of the PR is done
  • add a member from the localization team to translate it

@Lipata Lipata requested a review from wnvko March 30, 2020 09:15
Copy link
Contributor

@wnvko wnvko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add more info about display and input formats please

@IvayloG IvayloG requested review from wnvko and dafo March 30, 2020 13:35
en/components/date_time_editor.md Outdated Show resolved Hide resolved
en/components/date_time_editor.md Outdated Show resolved Hide resolved
en/components/date_time_editor.md Show resolved Hide resolved
en/components/date_time_editor.md Outdated Show resolved Hide resolved
wnvko
wnvko previously approved these changes Mar 30, 2020
en/components/toc.yml Outdated Show resolved Hide resolved
en/components/date_time_editor.md Outdated Show resolved Hide resolved
@Lipata
Copy link
Member

Lipata commented Apr 21, 2020

StackBlitz buttons are not working and please also follow the checklist at the top

@IvayloG IvayloG requested a review from Lipata April 22, 2020 06:00
@Lipata Lipata requested review from jackofdiamond5 and wnvko April 22, 2020 07:15
en/components/date_time_editor.md Outdated Show resolved Hide resolved
en/components/date_time_editor.md Outdated Show resolved Hide resolved
en/components/date_time_editor.md Show resolved Hide resolved
en/components/date_time_editor.md Outdated Show resolved Hide resolved
@IvayloG IvayloG requested a review from wnvko April 22, 2020 12:37
@Lipata Lipata merged commit c0fa061 into vNext Apr 24, 2020
@Lipata Lipata deleted the datetime-editor-topic-vNext branch April 24, 2020 08:49
randriova added a commit that referenced this pull request May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants