Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add z-index to the chip ghost #9933

Merged
merged 8 commits into from
Jul 30, 2021
Merged

Add z-index to the chip ghost #9933

merged 8 commits into from
Jul 30, 2021

Conversation

desig9stein
Copy link
Contributor

@desig9stein desig9stein commented Jul 28, 2021 •
edited
Loading

Related to https://github.com/IgniteUI/igniteui-angular-samples/issues/2749#event-5079198394

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@desig9stein desig9stein requested a review from simeonoff July 28, 2021 13:56
@simeonoff simeonoff added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Jul 29, 2021
@simeonoff simeonoff added ✅ status: verified Applies to PRs that have passed manual verification and removed 💥 status: in-test PRs currently being tested labels Jul 29, 2021
@gedinakova
Copy link
Contributor

@desig9stein It seems like this fix doesn't resolve the issue in samples, can you please check https://github.com/IgniteUI/igniteui-angular-samples/issues/2749?

@gedinakova gedinakova removed the ✅ status: verified Applies to PRs that have passed manual verification label Jul 29, 2021
@simeonoff simeonoff self-requested a review July 29, 2021 15:12
@desig9stein
Copy link
Contributor Author

@gedinakova Are you sure that you are testing with the fix? I can see that if the chip-ghost has a z-index bigger than the one of the igx-grid the chip is visible.

screenshot

@simeonoff simeonoff linked an issue Jul 30, 2021 that may be closed by this pull request
Group chips disappear during dragging when grids' displayDensity is different from 'comfortable' #9956
Closed
@gedinakova gedinakova added the ✅ status: verified Applies to PRs that have passed manual verification label Jul 30, 2021
@zdrawku zdrawku merged commit c350b1b into master Jul 30, 2021
@zdrawku zdrawku deleted the mpopov/chip-z-index branch July 30, 2021 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simeonoff simeonoff simeonoff approved these changes

Assignees

@gedinakova gedinakova

Labels
chip version: 12.1.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Group chips disappear during dragging when grids' displayDensity is different from 'comfortable'
4 participants
@desig9stein @gedinakova @simeonoff @zdrawku