Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tabs): update tabs if selectedIndex = -1 #9855

Merged
merged 11 commits into from
Jul 21, 2021
Merged

Conversation

onlyexeption
Copy link
Contributor

Closes #9820

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@onlyexeption onlyexeption added ❌ status: awaiting-test PRs awaiting manual verification tabs labels Jul 14, 2021
@DiyanDimitrov DiyanDimitrov requested review from gedinakova and removed request for DiyanDimitrov July 20, 2021 09:21
@zhosti zhosti added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Jul 20, 2021
@zhosti zhosti added ✅ status: verified Applies to PRs that have passed manual verification and removed 💥 status: in-test PRs currently being tested labels Jul 20, 2021
@gedinakova gedinakova self-requested a review July 21, 2021 13:02
@gedinakova gedinakova merged commit 27e1055 into master Jul 21, 2021
@gedinakova gedinakova deleted the ibarakov/fix-9820 branch July 21, 2021 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tabs version: 12.1.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IgxTabs: Dynamically adding a tab is not working properly
6 participants