Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement and expose a public CellType interface and API #9853

Merged
merged 80 commits into from
Jul 23, 2021
Merged

Implement and expose a public CellType interface and API #9853

merged 80 commits into from
Jul 23, 2021

Conversation

hanastasov
Copy link
Contributor

@hanastasov hanastasov commented Jul 14, 2021 •
edited
Loading

Closes #9555

Specification:
https://github.com/IgniteUI/igniteui-angular/wiki/Public-Cell-API-Specification

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@hanastasov hanastasov marked this pull request as ready for review July 14, 2021 12:03
@dobromirts
Copy link
Contributor

LogStateByIndex is returning cell value as 'undefined' when the grid is using Multi-row Layout.

@hanastasov hanastasov closed this Jul 22, 2021
@hanastasov hanastasov reopened this Jul 22, 2021
@zdrawku zdrawku added the 💥 status: in-test PRs currently being tested label Jul 23, 2021
@Aleksandyr Aleksandyr self-requested a review July 23, 2021 10:37
Aleksandyr
Aleksandyr previously approved these changes Jul 23, 2021
View reviewed changes
@Aleksandyr Aleksandyr self-requested a review July 23, 2021 11:02
Aleksandyr
Aleksandyr previously approved these changes Jul 23, 2021
View reviewed changes
@Lipata Lipata requested a review from Aleksandyr July 23, 2021 12:57
@zdrawku zdrawku added ✅ status: verified Applies to PRs that have passed manual verification and removed 💥 status: in-test PRs currently being tested labels Jul 23, 2021
@zdrawku zdrawku merged commit 959cd87 into master Jul 23, 2021
@zdrawku zdrawku deleted the hanastasov/public-cell-api-m branch July 23, 2021 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zdrawku zdrawku zdrawku approved these changes

@rkaraivanov rkaraivanov Awaiting requested review from rkaraivanov

@Aleksandyr Aleksandyr Awaiting requested review from Aleksandyr

Assignees
No one assigned
Labels
grid: general grid: hierarchical-grid grid: tree-grid squash-merge Merge PR with "Squash and Merge" option version: 13.0.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose a new cell-like object API for the data grids
4 participants
@hanastasov @dobromirts @Aleksandyr @zdrawku