Grid Selection --- 8.2.x #5651
Merged
Grid Selection --- 8.2.x #5651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into ddincheva/gridSelection
…into ddincheva/gridSelection
…into ddincheva/gridSelection
…into ddincheva/gridSelection
…into ddincheva/gridSelection
…into ddincheva/gridSelection
…/igniteui-angular into ddincheva/gridSelection
…into ddincheva/gridSelection
…into ddincheva/gridSelection
zdrawku
added
💥 status: in-test
ChronosSF
requested changes
Aug 23, 2019
|
|
||
| public getRowDataByID(rowID) { | ||
| if (!this.grid.primaryKey) { return rowID; } | ||
| const rowIndex = this.getRowIDs(this.grid.gridAPI.get_all_data()).indexOf(rowID); |
There was a problem hiding this comment.
Why do you have to map all PKs from the "get_all_data" collection just to get the record matching the rowID by index?
It will be faster if you just search for the record matching the rowID and breaking the search on a match.
Lipata
requested changes
Aug 23, 2019
zdrawku
added
✅ status: verified
ChronosSF
reviewed
Aug 26, 2019
ChronosSF
previously approved these changes
Aug 26, 2019
zdrawku
approved these changes
Aug 26, 2019
ChronosSF
approved these changes
Aug 26, 2019
Lipata
approved these changes
Aug 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4989
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes