Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Excel Style Filtering - load on demand #5588

Merged
merged 18 commits into from
Aug 14, 2019
Merged

Excel Style Filtering - load on demand #5588

merged 18 commits into from
Aug 14, 2019

Conversation

tachojelev
Copy link
Contributor

@tachojelev tachojelev commented Aug 6, 2019 •
edited
Loading

Closes #5448

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code
  • This PR includes API docs for newly added methods/properties
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes
  • This PR includes behavioral changes and the feature specification has been updated with them

@tachojelev
Copy link
Contributor Author

tachojelev commented Aug 7, 2019 •
edited
Loading

@simeonoff , @desig9stein , can you guys assist on centering the new default loading indicator in the excel-style-search component through our themes? It currently has an igx-excel-filter-loading class.

@tachojelev tachojelev marked this pull request as ready for review August 7, 2019 09:54
@tachojelev tachojelev added ❌ status: awaiting-test PRs awaiting manual verification and removed 🛠️ status: in-development Issues and PRs with active development on them labels Aug 7, 2019
kdinev
kdinev previously approved these changes Aug 7, 2019
View reviewed changes
@tachojelev tachojelev added 🛠️ status: in-development Issues and PRs with active development on them and removed ❌ status: awaiting-test PRs awaiting manual verification labels Aug 8, 2019
DiyanDimitrov
DiyanDimitrov previously approved these changes Aug 9, 2019
View reviewed changes
@tachojelev tachojelev dismissed stale reviews from DiyanDimitrov and kdinev via cb5553d August 9, 2019 08:14
@DiyanDimitrov DiyanDimitrov self-requested a review August 12, 2019 06:33
DiyanDimitrov
DiyanDimitrov previously approved these changes Aug 12, 2019
View reviewed changes
@tachojelev tachojelev added ❌ status: awaiting-test PRs awaiting manual verification and removed 🛠️ status: in-development Issues and PRs with active development on them labels Aug 12, 2019
@tachojelev tachojelev requested a review from kdinev August 12, 2019 06:37
DiyanDimitrov
DiyanDimitrov previously approved these changes Aug 12, 2019
View reviewed changes
@rmkrmk rmkrmk added 💥 status: in-test PRs currently being tested ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification 💥 status: in-test PRs currently being tested labels Aug 12, 2019
@DiyanDimitrov DiyanDimitrov merged commit 73f6ba5 into master Aug 14, 2019
@DiyanDimitrov DiyanDimitrov deleted the tzhelev/esf-load-on-demand branch August 14, 2019 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DiyanDimitrov DiyanDimitrov DiyanDimitrov approved these changes

@damyanpetev damyanpetev Awaiting requested review from damyanpetev

@kdinev kdinev Awaiting requested review from kdinev

Assignees

@rmkrmk rmkrmk

Labels
grid: excel-style-filtering grid: general grid: hierarchical-grid grid: tree-grid version: 8.2.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add remote data for Excel filter
4 participants
@tachojelev @kdinev @DiyanDimitrov @rmkrmk