Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(grid): row selection templating #4998 #5558

Merged
merged 78 commits into from
Sep 3, 2019
Merged

feat(grid): row selection templating #4998 #5558

merged 78 commits into from
Sep 3, 2019

Conversation

jackofdiamond5
Copy link
Member

@jackofdiamond5 jackofdiamond5 commented Jul 31, 2019 •
edited
Loading

Closes #4998

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code
  • This PR includes API docs for newly added methods/properties
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes
  • This PR includes behavioral changes and the feature specification has been updated with them

@jackofdiamond5 jackofdiamond5 requested a review from Lipata July 31, 2019 13:14
@jackofdiamond5 jackofdiamond5 changed the title Bpenkov/row selection templating Row selection templating Jul 31, 2019
@jackofdiamond5 jackofdiamond5 requested a review from wnvko July 31, 2019 13:16
jackofdiamond5 and others added 12 commits August 1, 2019 14:06
@jackofdiamond5
feat(tree-grid): add row-selection templating #4998
653ee56
@jackofdiamond5
refactor(grid): replace any with strict types; update HeadSelectorSta…
e62df92 
…tus enum
@Lipata
test(grid): initial test spec file #4998
d485d5c
@jackofdiamond5
refactor(grid/tree-grid): expose selectedCount, totalCount in head co…
8de532b 
…ntext
@jackofdiamond5
Merge branch 'bpenkov/row-selection-templating' of https://github.com…
c7b3211 
…/IgniteUI/igniteui-angular into bpenkov/row-selection-templating
@jackofdiamond5
refactor(grid-base): expose selectedRowsCount and totalRowsCount
814844c
@jackofdiamond5
feat(hgrid): add row-selection templating #4998
ee7b766
@jackofdiamond5
test(grid-selection): update should select all rows programatically #…
bcb3ef3 
…4998
@jackofdiamond5
refactor(igx-selection): pass TemplateRef to directives' constructors
83559e4
@jackofdiamond5
refactor(grid): remove unneeded public props; keep row index on grid …
19559c2 
…paging
@jackofdiamond5
refactor(treeGrid): remove unneeded public props; keep row index on g…
261f035 
…rid paging
@jackofdiamond5
refactor(hgrid): root grid and row islands can template selectors sep…
9042d55 
…arately
@jackofdiamond5
refactor(grid-common): add IgxSelectorsModule to exports arr
128f3ee
@jackofdiamond5
refactor(grid/tree-grid/hgrid): use grid.data in head context
b95740e
@jackofdiamond5
Merge branch 'master' of https://github.com/IgniteUI/igniteui-angular …
5d7a2e4 
…into bpenkov/row-selection-templating
@jackofdiamond5
refactor(grid): use indexes from filteredSortedData for row numbering
c8ca67a
@jackofdiamond5
refactor(hgrid/hgrid-row): include row selection methods in header/ro…
35dea3c 
…w contexts
@jackofdiamond5
chore(grid): fix lint errors
3040e08 
- grid/tree-grid/hgrid: fix context indentation in templates
@jackofdiamond5
Merge branch 'ddincheva/gridSelection' of https://github.com/IgniteUI…
75ad7a7 
…/igniteui-angular into bpenkov/row-selection-templating
@jackofdiamond5
Merge branch 'ddincheva/gridSelection' of https://github.com/IgniteUI…
37a7e66 
…/igniteui-angular into bpenkov/row-selection-templating
@damyanpetev damyanpetev added the squash-merge Merge PR with "Squash and Merge" option label Sep 2, 2019
wnvko
wnvko previously requested changes Sep 2, 2019
View reviewed changes
projects/igniteui-angular/src/lib/grids/grid-base.component.ts Outdated Show resolved Hide resolved
projects/igniteui-angular/src/lib/grids/grid-base.component.ts Outdated Show resolved Hide resolved
projects/igniteui-angular/src/lib/grids/grid/grid.component.html Outdated Show resolved Hide resolved
projects/igniteui-angular/src/lib/grids/hierarchical-grid/hierarchical-grid.component.html Outdated Show resolved Hide resolved
projects/igniteui-angular/src/lib/grids/hierarchical-grid/hierarchical-row.component.html Outdated Show resolved Hide resolved
projects/igniteui-angular/src/lib/grids/tree-grid/tree-grid-row.component.html Outdated Show resolved Hide resolved
projects/igniteui-angular/src/lib/grids/tree-grid/tree-grid.component.html Outdated Show resolved Hide resolved
damyanpetev
damyanpetev requested changes Sep 2, 2019
View reviewed changes
projects/igniteui-angular/src/lib/grids/grid-base.component.ts Outdated Show resolved Hide resolved
projects/igniteui-angular/src/lib/grids/grid-base.component.ts Show resolved Hide resolved
projects/igniteui-angular/src/lib/grids/grid/grid.component.html Outdated Show resolved Hide resolved
projects/igniteui-angular/src/lib/grids/grid/grid.component.html Outdated Show resolved Hide resolved
projects/igniteui-angular/src/lib/grids/grid/grid.component.ts Outdated Show resolved Hide resolved
projects/igniteui-angular/src/lib/grids/hierarchical-grid/hierarchical-row.component.ts Outdated Show resolved Hide resolved
projects/igniteui-angular/src/lib/grids/igx-row-selectors.module.ts Show resolved Hide resolved
projects/igniteui-angular/src/lib/grids/row.component.ts Outdated Show resolved Hide resolved
projects/igniteui-angular/src/lib/grids/tree-grid/tree-grid-row.component.html Show resolved Hide resolved
projects/igniteui-angular/src/lib/grids/tree-grid/tree-grid.component.html Outdated Show resolved Hide resolved
@Lipata Lipata changed the title Row selection templating feat(grid): row selection templating #4998 Sep 3, 2019
damyanpetev
damyanpetev reviewed Sep 3, 2019
View reviewed changes
projects/igniteui-angular/src/lib/grids/grid/grid-row.component.html
<ng-template *ngTemplateOutlet="
this.grid.rowSelectorTemplate ? this.grid.rowSelectorTemplate : rowSelectorBaseTemplate;
context: { $implicit: {
index: (this.grid.groupingExpressions ? this.grid.filteredSortedData.indexOf(this.rowData) : this.index) +
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, this can be moved to a getter in a separate PR.

damyanpetev
damyanpetev approved these changes Sep 3, 2019
View reviewed changes
Copy link
Member

@damyanpetev damyanpetev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@damyanpetev damyanpetev dismissed wnvko’s stale review September 3, 2019 14:58

Changes have been addressed

@Lipata Lipata merged commit e0af43d into master Sep 3, 2019
@Lipata Lipata deleted the bpenkov/row-selection-templating branch September 3, 2019 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damyanpetev damyanpetev damyanpetev approved these changes

@Lipata Lipata Lipata approved these changes

@wnvko wnvko Awaiting requested review from wnvko

Assignees

@dafo dafo

Labels
grid: general grid: hierarchical-grid grid: row-selection grid: tree-grid squash-merge Merge PR with "Squash and Merge" option version: 8.2.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Custom template for row selection checkbox
5 participants
@jackofdiamond5 @Lipata @damyanpetev @wnvko @dafo