Extend Grid API to allow custom keyboard navigation #4646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into ddincheva/customKBNav
…into ddincheva/customKBNav
…into ddincheva/customKBNav
…into ddincheva/customKBNav
…into ddincheva/customKBNav
…into ddincheva/customKBNav
…into ddincheva/customKBNav
ddincheva
added
🛠️ status: in-development
|
After initial testing, everything looks good. I have only two comments below:
|
…into ddincheva/customKBNav
…gniteui-angular into ddincheva/customKBNav
…gniteui-angular into ddincheva/customKBNav
ddincheva
added
❌ status: awaiting-test
nrobakova
added
💥 status: in-test
zdrawku
requested changes
May 8, 2019
CHANGELOG.md
Outdated
| - `onFocusChange` event is deprecated. | ||
| - `onGridKeydown` is exposed. The event will emit | ||
| `IGridKeydownEventArgs { targetType: GridKeydownTargetType; target: Object; event: Event; cancel: boolean; }` | ||
| - `navigateTo(rowIndex: number, visibleColumnIndex: number, callback({targetType, target: Object }))` - this method allows you to navigate to a randon position in the grid; |
There was a problem hiding this comment.
Suggested change
| - `navigateTo(rowIndex: number, visibleColumnIndex: number, callback({targetType, target: Object }))` - this method allows you to navigate to a randon position in the grid; | |
| - `navigateTo(rowIndex: number, visibleColumnIndex: number, callback({targetType, target: Object }))` - this method allows you to navigate to a position in the grid based on provided `rowindex` and `visibleColumnIndex`; |
zdrawku
requested changes
May 8, 2019
…gniteui-angular into ddincheva/customKBNav
nrobakova
added
✅ status: verified
zdrawku
approved these changes
May 10, 2019
mpavlinov
reviewed
May 10, 2019
| return nextRow ? this.verticalScrollContainer.igxForOf.indexOf(nextRow) : currentRowIndex; | ||
| } | ||
|
|
||
| private isValidPosition(rowIndex, colIndex) { |
There was a problem hiding this comment.
Doesn't have return type
| } | ||
| } | ||
|
|
||
| public getPreviousCell(currRowIndex: number, curVisibleColIndex: number, callback: (IgxColumnComponent) => boolean = null) { |
There was a problem hiding this comment.
Public API. Doesn't have description and code snippet.
Also there is no return type. You should introduce a new interface.
| } | ||
| } | ||
|
|
||
| public getNextCell(currRowIndex: number, curVisibleColIndex: number, callback: (IgxColumnComponent) => boolean = null) { |
There was a problem hiding this comment.
Public API. Doesn't have description and code snippet.
Also there is no return type. You should introduce a new interface.
| @@ -4884,6 +4905,136 @@ export abstract class IgxGridBaseComponent extends DisplayDensityBase implements | |||
| directive.scrollTo(goal); | |||
| } | |||
|
|
|||
| public navigateTo(rowIndex: number, visibleColIndex = -1, cb: Function = null) { | |||
There was a problem hiding this comment.
Public API. Doesn't have description and code snippet.
mpavlinov
reviewed
May 10, 2019
| return {rowIndex: currRowIndex, visibleColumnIndex: nextCellIndex}; | ||
| } else { | ||
| if (colIndexes.length === 0 || this.getNextDataRowIndex(currRowIndex) === currRowIndex) { | ||
| return {rowIndex: this.getNextDataRowIndex(currRowIndex), visibleColumnIndex: curVisibleColIndex}; |
There was a problem hiding this comment.
Please introduce a new type/interface. We don't want anonymous objects. See "Anonymous objects is a no-no."
| return {rowIndex: currRowIndex, visibleColumnIndex: prevCellIndex}; | ||
| } else { | ||
| if (colIndexes.length === 0 || this.getPrevDataRowIndex(currRowIndex) === currRowIndex) { | ||
| return {rowIndex: this.getPrevDataRowIndex(currRowIndex), visibleColumnIndex: curVisibleColIndex}; |
There was a problem hiding this comment.
Please introduce a new type/interface.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4054
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes