Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(date-picker): Fixed spinning only when the editor is focused #3034 #4027

Merged
merged 7 commits into from
Feb 27, 2019
Merged

fix(date-picker): Fixed spinning only when the editor is focused #3034 #4027

merged 7 commits into from
Feb 27, 2019

Conversation

sboykova
Copy link
Contributor

Related to #3034

Spinning with mouse wheel should be done only if the editable date picker is focused.

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code
  • This PR includes API docs for newly added methods/properties
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes
  • This PR includes behavioral changes and the feature specification has been updated with them

@sboykova sboykova requested a review from SAndreeva February 26, 2019 09:56
@SAndreeva SAndreeva added 💥 status: in-test PRs currently being tested ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification 💥 status: in-test PRs currently being tested labels Feb 27, 2019
SAndreeva
SAndreeva previously approved these changes Feb 27, 2019
View reviewed changes
@SAndreeva SAndreeva requested a review from bkulov February 27, 2019 08:57
bkulov
bkulov previously approved these changes Feb 27, 2019
View reviewed changes
@sboykova sboykova dismissed stale reviews from bkulov and SAndreeva via a2035e6 February 27, 2019 10:01
@bkulov bkulov merged commit 6fe0289 into master Feb 27, 2019
@bkulov bkulov deleted the sboykova/editable-date-picker-fixes branch February 27, 2019 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkulov bkulov bkulov approved these changes

@SAndreeva SAndreeva SAndreeva left review comments

Assignees

@SAndreeva SAndreeva

Labels
📅 date-picker version: 7.2.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sboykova @bkulov @SAndreeva