Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calculate width before opening the drop down #4008

Merged
merged 3 commits into from
Feb 25, 2019
Merged

Calculate width before opening the drop down #4008

merged 3 commits into from
Feb 25, 2019

Conversation

Lipata
Copy link
Member

@Lipata Lipata commented Feb 25, 2019

Closes #4007

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code
  • This PR includes API docs for newly added methods/properties
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes
  • This PR includes behavioral changes and the feature specification has been updated with them

@Lipata Lipata requested a review from damyanpetev February 25, 2019 14:31
@ViktorSlavov ViktorSlavov self-assigned this Feb 25, 2019
@ViktorSlavov ViktorSlavov added 💥 status: in-test PRs currently being tested ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification 💥 status: in-test PRs currently being tested labels Feb 25, 2019
@bazal4o bazal4o merged commit 3bb621d into master Feb 25, 2019
@bazal4o bazal4o deleted the nalipiev/autocomplete-horizontal branch February 25, 2019 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damyanpetev damyanpetev damyanpetev approved these changes

Assignees

@ViktorSlavov ViktorSlavov

Labels
autocomplete version: 7.2.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Setting custom settings for Horizontal direction and start point shows drop down incorrectly
4 participants
@Lipata @damyanpetev @bazal4o @ViktorSlavov