Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(date-picker): Fixed import and hide function #3034 #3961

Merged
merged 3 commits into from
Feb 20, 2019
Merged

fix(date-picker): Fixed import and hide function #3034 #3961

merged 3 commits into from
Feb 20, 2019

Conversation

sboykova
Copy link
Contributor

Related to #3034

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code
  • This PR includes API docs for newly added methods/properties
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes
  • This PR includes behavioral changes and the feature specification has been updated with them

@sboykova sboykova added 🐛 bug Any issue that describes a bug 📅 date-picker labels Feb 20, 2019
@sboykova sboykova requested a review from bkulov February 20, 2019 16:04
@sboykova sboykova added version: 7.2.x and removed 🐛 bug Any issue that describes a bug labels Feb 20, 2019
@bkulov bkulov added the ✅ status: verified Applies to PRs that have passed manual verification label Feb 20, 2019
bkulov
bkulov suggested changes Feb 20, 2019
View reviewed changes
Copy link
Contributor

@bkulov bkulov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix circular dependencies too.

@bkulov bkulov merged commit 4dfcaf2 into master Feb 20, 2019
@bkulov bkulov deleted the sboykova/fixes-date-picker branch February 20, 2019 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkulov bkulov bkulov approved these changes

Assignees

@bkulov bkulov

Labels
📅 date-picker version: 7.2.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sboykova @bkulov