Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3550 Fixed an issue with the initial validation fix. #3603

Merged
merged 5 commits into from
Jan 16, 2019
Merged

Conversation

gedinakova
Copy link
Contributor

@gedinakova gedinakova commented Jan 14, 2019

Closes #3550

Unnecessary valid/invalid styles were applied because _hasValidators was used a property instead of a method.

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code
  • This PR includes API docs for newly added methods/properties
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes
  • This PR includes behavioral changes and the feature specification has been updated with them

rkaraivanov
rkaraivanov previously approved these changes Jan 15, 2019
@tachojelev tachojelev added 💥 status: in-test PRs currently being tested ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification 💥 status: in-test PRs currently being tested labels Jan 15, 2019
SAndreeva
SAndreeva previously approved these changes Jan 15, 2019
@gedinakova gedinakova dismissed stale reviews from SAndreeva and rkaraivanov via a504c7b January 16, 2019 10:03
@kdinev kdinev merged commit 2853a25 into 6.2.x Jan 16, 2019
@kdinev kdinev deleted the fix-3550-6.2.x branch January 16, 2019 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
input version: 6.2.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants