Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(igx-grid): Expose column templates as inputs #3568

Merged
merged 2 commits into from
Jan 10, 2019

Conversation

rkaraivanov
Copy link
Member

Closes #3562

Additional information (check all that apply):

  • New functionality

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code
  • This PR includes CHANGELOG.MD updates for newly added functionality

@rkaraivanov rkaraivanov requested a review from kdinev January 10, 2019 11:03
@zdrawku zdrawku assigned ddincheva and unassigned zdrawku Jan 10, 2019
@ddincheva ddincheva added 💥 status: in-test PRs currently being tested ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification 💥 status: in-test PRs currently being tested labels Jan 10, 2019
@@ -600,7 +602,7 @@ export class IgxColumnComponent implements AfterContentInit {
*/
set bodyTemplate(template: TemplateRef<any>) {
this._bodyTemplate = template;
this.grid.markForCheck();
this.grid ? this.grid.cdr.markForCheck() : noop();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as #3567

@kdinev kdinev merged commit 1e944b5 into master Jan 10, 2019
@kdinev kdinev deleted the rkaraivanov/grid-column-templateref-input-master branch January 10, 2019 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
grid: general version: 7.2.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants