fix(igxInput): #3550 Setting required input value updates valid state. #3564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gedinakova
added
input
❌ status: awaiting-test
rkaraivanov
requested changes
Jan 10, 2019
| @@ -52,6 +52,9 @@ export class IgxInputDirective implements AfterViewInit, OnDestroy { | |||
| @Input('value') | |||
| set value(value: any) { | |||
| this.nativeElement.value = value; | |||
| if (!this.ngControl && this._hasValidators) { | |||
There was a problem hiding this comment.
This piece of code is repeated again in the input event handler Can we abstract it away, say as checkValidity() that returns an IgxInputState rather than copy it as it is?
rkaraivanov
approved these changes
Jan 10, 2019
tachojelev
added
💥 status: in-test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3550
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes