Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(progress): indeterminate progress implementation #3432

Merged
merged 19 commits into from
Jan 7, 2019
Merged

feat(progress): indeterminate progress implementation #3432

merged 19 commits into from
Jan 7, 2019

Conversation

simeonoff
Copy link
Collaborator

@simeonoff simeonoff commented Dec 13, 2018 •
edited
Loading

Closes #1997
Closes #1986

Additional information (check all that apply):

  • Bug fix
  • New functionality

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code
  • This PR includes API docs for newly added methods/properties
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR includes behavioral changes and the feature specification has been updated with them

rkaraivanov
rkaraivanov previously approved these changes Dec 13, 2018
View reviewed changes
@Aleksandyr Aleksandyr added 💥 status: in-test PRs currently being tested 🛠️ status: in-development Issues and PRs with active development on them and removed ❌ status: awaiting-test PRs awaiting manual verification 💥 status: in-test PRs currently being tested labels Dec 13, 2018
@Aleksandyr
Copy link
Contributor

Progress value should not be updated when indeterminate mode is on.

@Aleksandyr Aleksandyr added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed 🛠️ status: in-development Issues and PRs with active development on them labels Dec 13, 2018
@Aleksandyr Aleksandyr added ✅ status: verified Applies to PRs that have passed manual verification and removed ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. labels Dec 14, 2018
@zdrawku zdrawku changed the base branch from master to 7.1.x December 18, 2018 14:40
@rkaraivanov rkaraivanov merged commit d2e430b into 7.1.x Jan 7, 2019
@rkaraivanov rkaraivanov deleted the indeterminate-progress branch January 7, 2019 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkaraivanov rkaraivanov rkaraivanov approved these changes

@Aleksandyr Aleksandyr Aleksandyr approved these changes

@kdinev kdinev Awaiting requested review from kdinev

@desig9stein desig9stein Awaiting requested review from desig9stein

Assignees

@StefanIvanov StefanIvanov

@Aleksandyr Aleksandyr

@nrobakova nrobakova

@DaniMarinov DaniMarinov

Labels
circular-progress feature progress-bar version: 7.1.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@simeonoff @Aleksandyr @rkaraivanov @StefanIvanov @nrobakova @DaniMarinov @zdrawku @kdinev