Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(shell-strings): add some shell strings which should be localized #3239

Merged
merged 6 commits into from
Dec 3, 2018
Merged

chore(shell-strings): add some shell strings which should be localized #3239

merged 6 commits into from
Dec 3, 2018

Conversation

Aleksandyr
Copy link
Contributor

@Aleksandyr Aleksandyr commented Nov 30, 2018 •
edited
Loading

Closes #3237

Additional information (check all that apply):

  • Documentation

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes API docs for newly added methods/properties

@Aleksandyr Aleksandyr requested a review from zdrawku November 30, 2018 08:28
@Aleksandyr
Copy link
Contributor Author

@zdrawku The committed strings should be localized and after the PR is merged the new version should be tagged and respectively updated here.

@zdrawku zdrawku added ✅ status: verified Applies to PRs that have passed manual verification status: localized and removed 🛠️ status: in-development Issues and PRs with active development on them status: pending-localization labels Dec 3, 2018
@zdrawku zdrawku merged commit 7c4fa4b into 7.0.x Dec 3, 2018
@zdrawku zdrawku deleted the add-shell-strings-7.0.x branch December 3, 2018 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valadzhov valadzhov valadzhov left review comments

@zdrawku zdrawku zdrawku approved these changes

Assignees

@zdrawku zdrawku

Labels
status: localized typedoc version: 7.0.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Aleksandyr @valadzhov @zdrawku