Prevenitng redundant method calls on value property when initialized with an empty string(master) #3042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HristoP96
added
🐛 bug
ddincheva
added
💥 status: in-test
ddincheva
added
✅ status: verified
ddincheva
previously approved these changes
Nov 21, 2018
kdinev
requested changes
Nov 21, 2018
| @@ -599,7 +599,7 @@ export class IgxDatePickerComponent implements ControlValueAccessor, EditorProvi | |||
| * @hidden | |||
| */ | |||
| public handleSelection(date: Date) { | |||
| if (this.value !== null && this.value !== undefined) { | |||
| if (this.value !== null && this.value !== undefined && (this.value as any) !== '') { | |||
There was a problem hiding this comment.
Just do a check if this.value !== ''. In fact, just change this to a truthy check if (this.value)
added 3 commits
November 21, 2018 12:41
…into hPopov/fix-issue-3021/master
…iteUI/igniteui-angular into hPopov/fix-issue-3021/master
hanastasov
approved these changes
Nov 21, 2018
kdinev
approved these changes
Nov 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3021 .