Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(migrations,ng-add): turn on encapsulation for devkit/schematics deps #13732

Merged
merged 4 commits into from
Dec 5, 2023
Merged

fix(migrations,ng-add): turn on encapsulation for devkit/schematics deps #13732

merged 4 commits into from
Dec 5, 2023

Conversation

damyanpetev
Copy link
Member

Cherry pick of #13712
Related to #13668

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@damyanpetev damyanpetev requested a review from Lipata December 5, 2023 15:01
@Lipata Lipata added the 💥 status: in-test PRs currently being tested label Dec 5, 2023
@Lipata Lipata self-assigned this Dec 5, 2023
@Lipata Lipata added ✅ status: verified Applies to PRs that have passed manual verification and removed 💥 status: in-test PRs currently being tested labels Dec 5, 2023
@Lipata Lipata merged commit 438e8d2 into master Dec 5, 2023
5 checks passed
@Lipata Lipata deleted the dpetev/migrations-17-master branch December 5, 2023 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lipata Lipata Lipata approved these changes

Assignees

@Lipata Lipata

Labels
migrations ng add version: 17.1.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@damyanpetev @Lipata