Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:(input-group) fluent theme styles #11150

Merged
merged 3 commits into from
Mar 9, 2022

Conversation

desig9stein
Copy link
Contributor

@desig9stein desig9stein commented Mar 2, 2022

Closes #11145

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

Copy link
Contributor

@StefanIvanov StefanIvanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to update the caret color on focus from primary 500 to grays 900

@StefanIvanov
Copy link
Contributor

StefanIvanov commented Mar 2, 2022

You also need to update the caret color on focus from primary 500 to grays 900

And one more thing, do you plan to update the disabled styles of the fluent input as well with this PR or it will be a separate task? The idle and filled state also should be updated, more specifically the border color.

@desig9stein
Copy link
Contributor Author

desig9stein commented Mar 2, 2022

@StefanIvanov I will update the issue with all the required changes. I will fix them all with this PR

@desig9stein desig9stein changed the title fix:(input-group) fluent theme input focus styles fix:(input-group) fluent theme styles Mar 2, 2022
- Fix idle caret color.
- Fix border color.
- Remove unused placeholders.
@desig9stein desig9stein requested a review from StefanIvanov March 4, 2022 09:37
@simeonoff
Copy link
Collaborator

simeonoff commented Mar 8, 2022

Actually, the styles differ from the reference implementation in Fluent UI. The focused styles are achieved using border and not box-shadow. The box shouldn't visibly grow on hover/focus. Please, take a look at how the design is implemented in the Ignite UI for Web Components. I will merge it as it is here, but we will need to make further changes to make sure that web components and angular look and behave the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fluent inputs styles.
3 participants