-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix:(input-group) fluent theme styles #11150
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You also need to update the caret color on focus from primary 500 to grays 900
And one more thing, do you plan to update the disabled styles of the fluent input as well with this PR or it will be a separate task? The idle and filled state also should be updated, more specifically the border color. |
@StefanIvanov I will update the issue with all the required changes. I will fix them all with this PR |
- Fix idle caret color. - Fix border color. - Remove unused placeholders.
Actually, the styles differ from the reference implementation in Fluent UI. The focused styles are achieved using border and not box-shadow. The box shouldn't visibly grow on hover/focus. Please, take a look at how the design is implemented in the Ignite UI for Web Components. I will merge it as it is here, but we will need to make further changes to make sure that web components and angular look and behave the same. |
Closes #11145
Additional information (check all that apply):
Checklist:
feature/README.MD
updates for the feature docsREADME.MD
CHANGELOG.MD
updates for newly added functionalityng update
migrations for the breaking changes (migrations guidelines)