Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(drag-drop): Fix ghost template not cleared when used with ngFor directive to switch elements. #11108

Merged
merged 10 commits into from
Mar 8, 2022

Conversation

skrustev
Copy link
Member

Closes #10968

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@skrustev skrustev added ❌ status: awaiting-test PRs awaiting manual verification version: 13.1.x labels Feb 25, 2022
@3phase 3phase added 💥 status: in-test PRs currently being tested ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification 💥 status: in-test PRs currently being tested labels Feb 25, 2022
dkamburov
dkamburov previously approved these changes Feb 28, 2022
@dkamburov
Copy link
Contributor

@skrustev There seems to be 2 failing tests

@ChronosSF ChronosSF changed the base branch from master to 13.1.x March 2, 2022 10:30
@kdinev kdinev merged commit 833634c into 13.1.x Mar 8, 2022
@kdinev kdinev deleted the skrastev/fix-10968 branch March 8, 2022 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
drag-drop grid: pivot version: 13.1.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drag ghost artifacts remain on dragEnd next to igxDrag owner element when ngFor is used
5 participants