Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(selectionDirective): added number selection #10863

Merged
merged 12 commits into from
Feb 8, 2022
Merged

fix(selectionDirective): added number selection #10863

merged 12 commits into from
Feb 8, 2022

Conversation

tishko0
Copy link
Contributor

@tishko0 tishko0 commented Jan 19, 2022 •
edited
Loading

Closes #10806

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@tishko0 tishko0 added ❌ status: awaiting-test PRs awaiting manual verification version: 13.0.x labels Jan 19, 2022
@wnvko wnvko self-requested a review January 20, 2022 09:52
@tishko0 tishko0 changed the title fix(selectionDirective): adden number selection fix(selectionDirective): added number selection Jan 25, 2022
@wnvko wnvko self-requested a review January 26, 2022 10:17
@RivaIvanova RivaIvanova added 💥 status: in-test PRs currently being tested ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification 💥 status: in-test PRs currently being tested labels Feb 8, 2022
@teodosiah teodosiah merged commit 19cd3ad into master Feb 8, 2022
@teodosiah teodosiah deleted the ttonev-fix-10806 branch February 8, 2022 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wnvko wnvko wnvko approved these changes

Assignees

@RivaIvanova RivaIvanova

Labels
text-selection version: 13.0.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IgxTextSelection errors for input[type=number]
4 participants
@tishko0 @wnvko @RivaIvanova @teodosiah