Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(grid): safe guard against grid.addRow(undefined) #10587

Merged
merged 2 commits into from
Nov 22, 2021
Merged

fix(grid): safe guard against grid.addRow(undefined) #10587

merged 2 commits into from
Nov 22, 2021

Conversation

hanastasov
Copy link
Contributor

@hanastasov hanastasov commented Nov 22, 2021 •
edited
Loading

Closes (#10582)

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@hanastasov hanastasov added ❌ status: awaiting-test PRs awaiting manual verification grid: general labels Nov 22, 2021
@zdrawku zdrawku added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Nov 22, 2021
@Volen99 Volen99 added the ✅ status: verified Applies to PRs that have passed manual verification label Nov 22, 2021
@zdrawku zdrawku merged commit 8608eb2 into master Nov 22, 2021
@zdrawku zdrawku deleted the hanastasov/13-fixes branch November 22, 2021 10:02
@hanastasov hanastasov removed the 💥 status: in-test PRs currently being tested label Nov 22, 2021
@Volen99 Volen99 linked an issue Jan 25, 2022 that may be closed by this pull request
Error: Cannot read properties of undefined (reading 'summaries') #10582
Closed
@Volen99 Volen99 mentioned this pull request Jan 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zdrawku zdrawku zdrawku approved these changes

Assignees

@zdrawku zdrawku

@Volen99 Volen99

Labels
grid: general version: 13.0.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error: Cannot read properties of undefined (reading 'summaries')
3 participants
@hanastasov @zdrawku @Volen99