Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expand only one panel when SingleBranchExpand is set to true #10465

Merged
merged 5 commits into from
Nov 16, 2021

Conversation

MonikaKirkova
Copy link
Contributor

Closes #10242

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

Copy link
Contributor

@wnvko wnvko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

having several panels expanded and setting singleBranchExpand to true leaves all the panels expanded. Is this correct?

@wnvko wnvko self-requested a review November 12, 2021 09:03
@MonikaKirkova
Copy link
Contributor Author

having several panels expanded and setting singleBranchExpand to true leaves all the panels expanded. Is this correct?

Yes, by setting singleBranchExpand to true the expanded panels are preserved until another panel is expanded.

@teodosiah teodosiah assigned mmart1n and unassigned viktorkombov Nov 16, 2021
@mmart1n mmart1n added 💥 status: in-test PRs currently being tested ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification 💥 status: in-test PRs currently being tested labels Nov 16, 2021
@teodosiah teodosiah merged commit df93331 into master Nov 16, 2021
@teodosiah teodosiah deleted the mkirkova/fix-10242-master branch November 16, 2021 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accordion version: 13.0.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IgxAccordion SingleBranchExpand inconsistent behavior
6 participants