Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(grid): remove aria-activedescendant on role="rowgroup" #10432

Merged
merged 2 commits into from
Nov 10, 2021
Merged

fix(grid): remove aria-activedescendant on role="rowgroup" #10432

merged 2 commits into from
Nov 10, 2021

Conversation

Volen99
Copy link
Contributor

@Volen99 Volen99 commented Nov 8, 2021 •
edited
Loading

Closes #10392

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@Volen99 Volen99 requested a review from hanastasov November 8, 2021 11:59
@Volen99 Volen99 added grid: active-node Grid ActiveNode ❌ status: awaiting-test PRs awaiting manual verification grid: general and removed grid: active-node Grid ActiveNode labels Nov 8, 2021
@Volen99 Volen99 self-assigned this Nov 8, 2021
@hanastasov hanastasov requested a review from ddincheva November 8, 2021 13:01
@katherinedragieva katherinedragieva added 💥 status: in-test PRs currently being tested ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification 💥 status: in-test PRs currently being tested labels Nov 8, 2021
@Volen99 Volen99 added the ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. label Nov 9, 2021
@kdinev kdinev removed the ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. label Nov 9, 2021
@hanastasov hanastasov merged commit 57b0a13 into master Nov 10, 2021
@hanastasov hanastasov deleted the VDyulgerov/fix-aria-activedescendant-master branch November 10, 2021 07:15
@GibletJr GibletJr mentioned this pull request Nov 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katherinedragieva katherinedragieva katherinedragieva approved these changes

@hanastasov hanastasov Awaiting requested review from hanastasov

@ddincheva ddincheva Awaiting requested review from ddincheva

Assignees

@katherinedragieva katherinedragieva

Labels
aria-support grid: general version: 13.0.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

igx-grid-thead: aria-activedescendant attribute not allowed for an element's role
6 participants
@Volen99 @katherinedragieva @kdinev @hanastasov @ddincheva @Lipata