Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(exporters): add providedIn root to exporters #10220

Merged
merged 9 commits into from
Oct 7, 2021
Merged

feat(exporters): add providedIn root to exporters #10220

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
6d59501
feat(exporters): add providedIn root to exporters
igdmdimitrov Sep 30, 2021
3ff2bdc
Merge branch 'master' into dmdimitrov/exporters-import
igdmdimitrov Sep 30, 2021
c014257
Merge branch 'master' into dmdimitrov/exporters-import
igdmdimitrov Oct 1, 2021
cc6ce6f
Merge branch 'master' into dmdimitrov/exporters-import
igdmdimitrov Oct 4, 2021
99c0401
Merge branch 'master' into dmdimitrov/exporters-import
gedinakova Oct 5, 2021
21a28ac
chore(*): removed optional decorators
igdmdimitrov Oct 6, 2021
196a289
Merge branch 'master' into dmdimitrov/exporters-import
kdinev Oct 7, 2021
5a5a583
chore(*): updated changelog
igdmdimitrov Oct 7, 2021
80dd86d
Merge branch 'dmdimitrov/exporters-import'
igdmdimitrov Oct 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions projects/igniteui-angular/src/lib/grids/toolbar/grid-toolbar-exporter.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,8 +108,8 @@ export class IgxGridToolbarExporterComponent extends BaseToolbarDirective {

constructor(
@Host() protected toolbar: IgxGridToolbarComponent,
@Optional() private excelExporter: IgxExcelExporterService,
@Optional() private csvExporter: IgxCsvExporterService,
private excelExporter: IgxExcelExporterService,
private csvExporter: IgxCsvExporterService,
) {
super(toolbar);
}
Expand Down
4 changes: 3 additions & 1 deletion projects/igniteui-angular/src/lib/services/csv/csv-exporter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,9 @@ export interface ICsvExportEndedEventArgs extends IBaseEventArgs {
* this.csvExportService.exportData(this.localData, opt);
* ```
*/
@Injectable()
@Injectable({
providedIn: 'root',
})
export class IgxCsvExporterService extends IgxBaseExporter {
/**
* This event is emitted when the export process finishes.
Expand Down
4 changes: 3 additions & 1 deletion projects/igniteui-angular/src/lib/services/excel/excel-exporter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,9 @@ const EXCEL_MAX_COLS = 16384;
* this.excelExportService.exportData(this.localData, new IgxExcelExporterOptions("FileName"));
* ```
*/
@Injectable()
@Injectable({
providedIn: 'root',
})
export class IgxExcelExporterService extends IgxBaseExporter {
private static ZIP_OPTIONS = { compression: 'DEFLATE', type: 'base64' } as JSZip.JSZipGeneratorOptions<'base64'>;

Expand Down
4 changes: 1 addition & 3 deletions src/app/app.module.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { HttpClientModule, HTTP_INTERCEPTORS } from '@angular/common/http';
import { FormsModule, ReactiveFormsModule } from '@angular/forms';
import { NgModule } from '@angular/core';
import {
IgxIconModule, IgxBottomNavModule, IgxGridModule, IgxExcelExporterService, IgxCsvExporterService, IgxOverlayService,
IgxIconModule, IgxBottomNavModule, IgxGridModule, IgxOverlayService,
IgxDragDropModule, IgxDividerModule, IgxTreeGridModule, IgxHierarchicalGridModule, IgxInputGroupModule,
IgxIconService, DisplayDensityToken, DisplayDensity,
IgxDateTimeEditorModule, IgxDateRangePickerModule, IgxButtonModule, IgxActionStripModule, GridBaseAPIService, IgxButtonGroupModule,
Expand Down Expand Up @@ -327,9 +327,7 @@ const components = [
HierarchicalRemoteService,
GridBaseAPIService,
IgxGridHierarchicalPipe,
IgxExcelExporterService,
IgxIconService,
IgxCsvExporterService,
IgxOverlayService,
{ provide: DisplayDensityToken, useFactory: () => ({ displayDensity: DisplayDensity.comfortable }) },
{
Expand Down