Fixes column width not updating when grouping is cleared #10135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3phase
added
❌ status: awaiting-test
viktorkombov
approved these changes
Sep 16, 2021
VMihalkov
added
💥 status: in-test
MayaKirova
reviewed
Sep 16, 2021
| @@ -672,6 +672,7 @@ export class IgxGridComponent extends IgxGridBaseDirective implements GridType, | |||
| */ | |||
| public clearGrouping(name?: string | Array<string>): void { | |||
| this._gridAPI.clear_groupby(name); | |||
| this.calculateGridSizes(); | |||
| this.notifyChanges(true); | |||
There was a problem hiding this comment.
notifyChanges can be removed since its main purpose is to force reflow calculation on the next detection cycle. But with this change the calculation is already done explicitly so there's no point to calculate again on the next detection cycle.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10081
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)