Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overlay wrapper animation should start together with overlay element animation #9882

Closed
Lipata opened this issue Jul 19, 2021 · 2 comments · Fixed by #10232
Closed

Overlay wrapper animation should start together with overlay element animation #9882

Lipata opened this issue Jul 19, 2021 · 2 comments · Fixed by #10232
Assignees
@Lipata @PlamenaMiteva
Labels
🐛 bug Any issue that describes a bug overlay version: 12.2.x version: 13.0.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.

Comments

@Lipata
Copy link
Member

Lipata commented Jul 19, 2021 •
edited
Loading

Is your feature request related to a problem? Please describe.

Overlay wrapper animation should start together with overlay element animation. In cases where animation duration is bigger, it is obvious that the wrapper animation is starting after the animation of the element is finished (see igx-dialog's closing animation):

overlay_anim_demo

The closing animation in Material:

117975646-8e7c0e00-b337-11eb-805c-8965ce95ecd0
@Lipata Lipata self-assigned this Jul 19, 2021
PlamenaMiteva added a commit that referenced this issue Oct 4, 2021
@PlamenaMiteva
fix(overlay): move addModalClasses to show method #9882
081af5f
PlamenaMiteva added a commit that referenced this issue Oct 4, 2021
@PlamenaMiteva
fix(overlay): implement removeModalClasses method #9882
709b5fe
@wnvko wnvko mentioned this issue Oct 4, 2021
Merged
14 tasks
@wnvko wnvko added 🐛 bug Any issue that describes a bug and removed 📈 enhancement labels Oct 4, 2021
@wnvko
Copy link
Contributor

wnvko commented Oct 4, 2021

this was working in old version and regressed with addition of attach and detach methods

PlamenaMiteva added a commit that referenced this issue Oct 4, 2021
@PlamenaMiteva
test(overlay): fix failing test #9882
f7e3a30
PlamenaMiteva added a commit that referenced this issue Oct 4, 2021
@PlamenaMiteva
chore(overlay): addressing comments #9882
b6dad79
PlamenaMiteva added a commit that referenced this issue Oct 5, 2021
@PlamenaMiteva
test(overlay): fix failing test #9882
7884a7e
PlamenaMiteva added a commit that referenced this issue Oct 5, 2021
@PlamenaMiteva
test(overlay): fix failing test #9882
bcf261c
PlamenaMiteva added a commit that referenced this issue Oct 5, 2021
@PlamenaMiteva
fix(overlay): move addModalClasses to show method #9882
74a609b
PlamenaMiteva added a commit that referenced this issue Oct 5, 2021
@PlamenaMiteva
fix(overlay): implement removeModalClasses method #9882
e3e8e45
PlamenaMiteva added a commit that referenced this issue Oct 5, 2021
@PlamenaMiteva
test(overlay): fix failing test #9882
f32a68a
PlamenaMiteva added a commit that referenced this issue Oct 5, 2021
@PlamenaMiteva
chore(overlay): addressing comments #9882
537ce39
PlamenaMiteva added a commit that referenced this issue Oct 5, 2021
@PlamenaMiteva
test(overlay): fix failing test #9882
03871b9
PlamenaMiteva added a commit that referenced this issue Oct 5, 2021
@PlamenaMiteva
test(overlay): fix failing test #9882
8b1607b
@PlamenaMiteva PlamenaMiteva mentioned this issue Oct 5, 2021
Merged
14 tasks
PlamenaMiteva added a commit that referenced this issue Oct 5, 2021
@PlamenaMiteva
test(overlay): addressing comments #9882
8a25b14
PlamenaMiteva added a commit that referenced this issue Oct 5, 2021
@PlamenaMiteva
test(overlay): addressing comments #9882
50d4ccb
@Lipata Lipata added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. version: 12.2.x and removed 🆕 status: new labels Oct 6, 2021
PlamenaMiteva added a commit that referenced this issue Oct 7, 2021
@PlamenaMiteva
fix(overlay): wrap class addition in RAF #9882
d019881
PlamenaMiteva added a commit that referenced this issue Oct 7, 2021
@PlamenaMiteva
fix(overlay): wrap class addition in RAF #9882
68ad335
PlamenaMiteva added a commit that referenced this issue Oct 8, 2021
@PlamenaMiteva
chore(overlay): addressing comments #9882
4b57255
PlamenaMiteva added a commit that referenced this issue Oct 8, 2021
@PlamenaMiteva
chore(overlay): addressing comments #9882
6027b17
@PlamenaMiteva
Copy link
Contributor

For some reason browsers fail to play the initial animation when element's background color has been changed like in the following sample. The issue is logged to the browsers and until resolved we have to use a workaround of wrapping the modal class application in requestAnimationFrame().

Lipata pushed a commit that referenced this issue Oct 11, 2021
@PlamenaMiteva
fix(overlay): overlay wrapper and element animation should start tog…
ca81912 
…ether #9882 (#10238)
Lipata pushed a commit that referenced this issue Oct 11, 2021
@PlamenaMiteva
fix(overlay): overlay wrapper and element animation should start tog…
7d069c2 
…ether #9882 (#10232)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Lipata Lipata

@PlamenaMiteva PlamenaMiteva

Labels
🐛 bug Any issue that describes a bug overlay version: 12.2.x version: 13.0.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Overlay wrapper and element animation should start together IgniteUI/igniteui-angular
3 participants
@Lipata @wnvko @PlamenaMiteva