Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

igx-grid Filter behavior #6973

Closed
kijomito opened this issue Mar 25, 2020 · 3 comments · Fixed by #7096 or #7188
Closed

igx-grid Filter behavior #6973

kijomito opened this issue Mar 25, 2020 · 3 comments · Fixed by #7096 or #7188
Assignees
Labels
browser: IE-11 Issues specific to the MS IE11 browser 🐛 bug Any issue that describes a bug filtering 🔥 🦊 browser: firefox Bug occurs under Mozilla Firefox 🧨 severity: medium 🌐 browser: edge Issues specific to the MS Edge browser grid: general version: 8.1.0 ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.

Comments

@kijomito
Copy link

I have the problem that the browsers behave differently. If I enter a comma in the filter of a column with the data type number in Chrome everything works. But in Firefox, IE, EDGE only an integer is adopted.

I'am using Windows 10 in German Language.

IgxGrid is set to German locale:
this.grid.locale = "de";

Version:
igniteui-angular 8.1.0

Browser Versions:
Edge: Version 80.0.361.69 and latest Windows 10 Version
Chrome: Version 80.0.3987.149
Firefox: 74.0

Steps to reproduce

  1. Open StackBlitz Example on Chrome and enter a Filter on UnitPrice
  2. Open StackBlitz Example on FireFox and enter a Filter on UnitPrice
  3. Open StackBlitz Example on Edge and enter a Filter on UnitPrice

Result

Filter behavior on number Field
On Dot Input:
Edge resets Filter.
Chrome resets Filter.
Chrome works with Comma!
Firefox only work with Dot in Filter ignores Comma.

Expected result

All Browsers working like Chrome with Comma for German Language.

Example on StackBlitz

https://stackblitz.com/edit/angular-xp1hw2

@dkamburov
Copy link
Contributor

@kijomito You should note that different browsers behave differently with input type="number". You can play around with that sample. Some of the browsers allow invalid characters, others don't. I also found this issue for Firefox - https://bugzilla.mozilla.org/show_bug.cgi?id=1199665. There might be one for Edge too.

I believe that you have a point that the value should not be reset even if not valid, so we would try resolving that.

@ChronosSF ChronosSF added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed 🛠️ status: in-development Issues and PRs with active development on them labels Apr 9, 2020
@MayaKirova
Copy link
Contributor

@kijomito Just to add some clarification on what we can and cannot resolve in relation to this.

We can prevent the input from being reverted if an invalid value is entered. Hence you will be able to enter values with the separator in Edge/Firefox as well – ex. “20,75”.
However, we cannot prevent browser specific issues with regional separators being considered as invalid for inputs with type number.

As Deyan mentioned, FireFox has issues with how it parses regional specific separators (like “,”) in numeric inputs.
Due to this if you type in “20,75” in FireFox for filtering, only the valid part of the number will be applied to the filter – “20”.

We will document this as a limitation to prevent future confusion. The related issue is: IgniteUI/igniteui-docfx#1880

ChronosSF added a commit that referenced this issue Apr 14, 2020
fix(filtering): Avoid resetting values for number inputs #6973
ChronosSF added a commit that referenced this issue Apr 14, 2020
fix(filtering): Avoid resetting values for number inputs #6973
@ChronosSF
Copy link
Member

The fix causes issues and a new fix will be proposed in the future.

@ChronosSF ChronosSF added 🆕 status: new and removed ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. labels Apr 21, 2020
ChronosSF added a commit that referenced this issue Apr 21, 2020
Revert "fix(filtering): Avoid resetting values for number inputs #6973"
ChronosSF added a commit that referenced this issue Apr 21, 2020
…-9.0.x

Revert "fix(filtering): Avoid resetting values for number inputs #6973"
ChronosSF added a commit that referenced this issue Apr 21, 2020
…-8.2.x

Revert "fix(filtering): Avoid resetting values for number inputs #6973"
@DiyanDimitrov DiyanDimitrov added 🛠️ status: in-development Issues and PRs with active development on them and removed 🆕 status: new labels Apr 22, 2020
@onlyexeption onlyexeption added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed 🛠️ status: in-development Issues and PRs with active development on them labels Apr 23, 2020
onlyexeption added a commit that referenced this issue Apr 27, 2020
DiyanDimitrov added a commit that referenced this issue Apr 29, 2020
fix(filtering): filter behavior on number type filter #6973
DiyanDimitrov added a commit that referenced this issue Apr 29, 2020
fix(filtering): filter behavior on number type filter #6973
DiyanDimitrov added a commit that referenced this issue Apr 30, 2020
fix(filtering): filter behavior on number type filter #6973
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser: IE-11 Issues specific to the MS IE11 browser 🐛 bug Any issue that describes a bug filtering 🔥 🦊 browser: firefox Bug occurs under Mozilla Firefox 🧨 severity: medium 🌐 browser: edge Issues specific to the MS Edge browser grid: general version: 8.1.0 ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
None yet
7 participants