Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Row selection template container padding #5764

Closed
damyanpetev opened this issue Sep 10, 2019 · 0 comments · Fixed by #5814
Closed

Row selection template container padding #5764

damyanpetev opened this issue Sep 10, 2019 · 0 comments · Fixed by #5814
Assignees
Labels
🐛 bug Any issue that describes a bug grid: row-selection version: 8.2.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.

Comments

@damyanpetev
Copy link
Member

Description

The Row selector templates (both header and per-row) are wrapped in a container w/ .igx-grid__cbx-selection that applies pretty sizable side padding that any user providing a custom template would have to figure out a way around.

  • igniteui-angular version: 8.2.x
  • browser:

Steps to reproduce

  1. Run samples from Add row selectors template samples for all grids igniteui-angular-samples#1368
  2. Go to http://localhost:4200/samples/grid/grid-selection-template-numbering
  3. Remove overridden style:
    https://github.com/IgniteUI/igniteui-angular-samples/blob/3788c6ea4d7bd828102b7d04027d8b79ea6e8f94/src/app/grid/grid-sample-selection-template-numbers/grid-sample-selection-template-numbers.component.scss#L41-L43
  4. Observe the resulting selector column sizes

Result

Selectors are now bumped by padding without the override
image

Expected result

Shouldn't need to override the padding intended for our default checkboxes template - that should be part of our template and not affect custom ones.

@jackofdiamond5 jackofdiamond5 added 🆕 status: new 🛠️ status: in-development Issues and PRs with active development on them and removed 🆕 status: new labels Sep 13, 2019
@jackofdiamond5 jackofdiamond5 added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed 🛠️ status: in-development Issues and PRs with active development on them labels Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Any issue that describes a bug grid: row-selection version: 8.2.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants