Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In some cases, click event is not triggered in igx-overlay #3595

Closed
sboykova opened this issue Jan 14, 2019 · 1 comment · Fixed by #3583
Closed

In some cases, click event is not triggered in igx-overlay #3595

sboykova opened this issue Jan 14, 2019 · 1 comment · Fixed by #3583
Assignees
@damyanpetev @wnvko
Labels
🐛 bug Any issue that describes a bug 📆 calendar overlay triage: blocking version: 7.2.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.

Comments

@sboykova
Copy link
Contributor

sboykova commented Jan 14, 2019 •
edited
Loading

Description

When the overlay is not modal, click event is not triggered

  • igniteui-angular version: 7.2.x
  • browser: All

Steps to reproduce

  1. Pull sboykova/editable-date-picker branch (pull-request), run demos and open the date picker page
  2. Open the drop-down of the Editable Date Picker clicking the calendar image on the left
  3. Click 2018 (year link) of the calendar, then click another year to select

Result

Click event is not fired and new year is not selected

Expected result

Click event to be triggered
@sboykova sboykova added 🐛 bug Any issue that describes a bug overlay version: 7.2.x labels Jan 14, 2019
@wnvko wnvko added 🛠️ status: in-development Issues and PRs with active development on them 📆 calendar and removed overlay labels Jan 15, 2019
@sboykova
Copy link
Contributor Author

This issue exists only when the overlay is not modal, when it is modal - the click event is fired without any changes in the code of the calendar.

@wnvko wnvko added the overlay label Jan 16, 2019
wnvko added a commit that referenced this issue Jan 18, 2019
@wnvko
fix(igxCalendar): add trackBy for months and years, #3595
8ac4095 
If calendar is shown in overlay, the overlay saves a reference
to calendar elementRef. Month and Year templates add click event
via host listener. However, both templates redraw themselves.
As a result of this elements, where the click event was added,
are lost. As a result click does not fire. To fix this we added
trackBy in ngFor both for Month and Year templates.
@sboykova sboykova mentioned this issue Jan 18, 2019
Merged
14 tasks
@wnvko wnvko added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed 🛠️ status: in-development Issues and PRs with active development on them labels Jan 28, 2019
bkulov pushed a commit that referenced this issue Feb 20, 2019
@sboykova @bkulov
editable date picker (#3583)
a311c0c 
* feat(date-picker): Initial changes to support edit field #3034

* refactor(themes): update date-picker theme after refactor

* feat(date-picker): Fixes in editable date-picker #3034

* feat(date-picker): Implementing edit mode #3034

* feat(date-picker): More changes #3034

* feat(date-picker): Added spinning of the date parts #3034

* feat(date-picker): Added spinning functionality and other fixes #3034

* feat(date-picker): Spinning issues fixes #3034

* chore(*): Some code changes

* feat(date-picker): Resolved merged changes #3034

* feat(date-picker): Reworked parts in editable mode #3034

* fix(igxCalendar): add trackBy for months and years, #3595

If calendar is shown in overlay, the overlay saves a reference
to calendar elementRef. Month and Year templates add click event
via host listener. However, both templates redraw themselves.
As a result of this elements, where the click event was added,
are lost. As a result click does not fire. To fix this we added
trackBy in ngFor both for Month and Year templates.

* feat(date-picker): Added spinning on mouse wheel #3583

* feat(date-picker): Added more functionality #3583

* feat(date-picker): Fixes in editing and spinning date parts #3583

* feat(date-picker): Added infinite loop when spinning #3583

* feat(date-picker): Fixes in editable date-picker #3583

* feat(date-picker): Fixes in edit mode #3583

* feat(date-picker): Fixes, refactoring #3583

* feat(date-picker): Disabled/special dates handling #3583

* feat(date-picker): Fixes in editable mode #3583

* feat(date-picker): Fixes in tests #3583

* feat(date-picker): Calendar and buttons added to new component #3583

* feat(date-picker): Fixed spinning of long months names #3583

* feat(date-picker): Fixed existing tests, refactoring #3583

* feat(date-picker): Reworked code, overlay settings exposed #3583

* feat(date-picker): Fixed styles bindings #3583

* fix(date-picker): Fixes in edit mode #3583

* fix(date-picker): Fixes, added tests for edit mode #3583

* fix(date-picker): Added alt+up key behavior, added tests #3583

* fix(date-picker): Fixed check for days in month #3583

* fix(date-picker): Fixes in edit mode #3583

* fix(date-picker): Changed date-picker mode in grid #3583

* fix(date-picker): Fixes in code and tests #3583

* feat(date-picker): Added some API comments and fixes #3583

* feat(date-picker): Added info in docs, fixed method name #3583

* fix(igx-grid): Add filter-row date-picker in grid's outlet, #3034

* feat(date-picker): fix broken behaviors after calendar merge #3583

* fix(date-picker): Requested changes done #3583

* fix(date-picker): Fixes in date-picker #3583

* fix(date-picker): Fixes in code #3583

* fix(date-picker): Fix in calendar opening #3583

* fix(grid): Enabled key down event for date-picker editor #3583

* fix(grid): failing tests #3583

* fix(grid): Removed not needed brackets #3583

* fix(grid): Removed unused openDialog event argument #3583

* fix(date-picker): Stopped propagation of spinning events #3583

* fix(date-picker): Fixed empty mask #3583

* fix(grid): failing test for locale #3583

* chore(*): try fixing flickering test #3583

* test(date-picker): Added new tests, fixes #3583

* test(date-picker): Fixed failing focus test #3583

* test(grid): remove detectChanges #3583

* test(date-picker): Added tests for editable date-picker #3583

* test(grid): enter edit mode -> update -> exit edit mode -> check #3583

* test(grid): use API calls to methods instead of using shift+tab #3583

* test(date-picker): Added more tests for editable date picker #3583
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@damyanpetev damyanpetev

@wnvko wnvko

Labels
🐛 bug Any issue that describes a bug 📆 calendar overlay triage: blocking version: 7.2.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

editable date picker IgniteUI/igniteui-angular
4 participants
@damyanpetev @bazal4o @wnvko @sboykova