Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pressing ESC on a cell in an editable column throws an error #3429

Closed
ViktorSlavov opened this issue Dec 13, 2018 · 0 comments
Closed

Pressing ESC on a cell in an editable column throws an error #3429

ViktorSlavov opened this issue Dec 13, 2018 · 0 comments
Assignees
@ViktorSlavov
Labels
🧨 severity: medium grid: cell-editing grid: general version: 6.2.x version: 7.1.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.

Comments

@ViktorSlavov
Copy link
Contributor

Description

Pressing the ESC key on a grid cell in an editable column when no cell is in edit mode throws an error.

  • igniteui-angular version: 7.0.x., 6.2.x
  • browser: N/A

Steps to reproduce

  1. Open Grid Cell Editing dev demo
  2. Select a cell in an editable column (e.g. first row, column 'Product ID')
  3. Press Escape
  4. Observe the console

Result

An error is thrown

Expected result

An error should not be thrown

Attachments

image
@ViktorSlavov ViktorSlavov self-assigned this Dec 13, 2018
ViktorSlavov added a commit that referenced this issue Dec 13, 2018
@ViktorSlavov
fix(grid): check for cell in edit in onKeyDownExitEdit, #3429
299d15a
ViktorSlavov added a commit that referenced this issue Dec 13, 2018
@ViktorSlavov
fix(grid): check for cell in edit in onKeyDownExitEdit, #3429
35bf2f5
This was referenced Dec 13, 2018
Merged
Closed
Merged
@ViktorSlavov ViktorSlavov added the ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. label Dec 13, 2018
@kdinev kdinev closed this as completed Jan 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ViktorSlavov ViktorSlavov

Labels
🧨 severity: medium grid: cell-editing grid: general version: 6.2.x version: 7.1.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kdinev @bazal4o @ViktorSlavov