Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is "date" a reserved css class name? #2287

Closed
ig-robstoffers opened this issue Aug 2, 2018 · 1 comment
Closed

Is "date" a reserved css class name? #2287

ig-robstoffers opened this issue Aug 2, 2018 · 1 comment
Assignees
@StefanIvanov @simeonoff
Labels
❓ question

Comments

@ig-robstoffers
Copy link
Contributor

Description

If I create a CSS class and call it "date" it appears to combine with another date class defined somewhere else that I'm not aware of.

  • igniteui-angular version: 6.1.2
  • browser: Google Chrome 67.0.3396.99

Steps to reproduce

  1. Run sample here: https://stackblitz.com/edit/angular-7rzufe

Result

The Date text is positioned weirdly. Look at the .date class in the chrome debugger and there are other CSS properties attached to the class that I did not specify.

Expected result

I should be able to use a css class named "date" unless it is reserved. In that case, is this documented somewhere?
@simeonoff
Copy link
Collaborator

@ig-robstoffers Yeah, this is definitely not desired. We will update the class names. Good thing those are outliers, we usually don't have class names like these.

simeonoff added a commit that referenced this issue Nov 22, 2018
@simeonoff
fix(calendar): make all class names unique
84a2481 
Closes #2287
@simeonoff simeonoff mentioned this issue Nov 22, 2018
Merged
3 tasks
simeonoff added a commit that referenced this issue Nov 22, 2018
@simeonoff
fix(calendar): make all class names unique
dc37cf0 
Closes #2287
simeonoff added a commit that referenced this issue Nov 22, 2018
@simeonoff
fix(calendar): make all class names unique
3d68211 
Closes #2287
@simeonoff simeonoff mentioned this issue Nov 22, 2018
Merged
kdinev pushed a commit that referenced this issue Nov 23, 2018
@kdinev
fix(calendar): make all class names unique (#3119)
d82baac 
* fix(calendar): make all class names unique

Closes #2287

* Update calendar.component.spec.ts

* test(grid-filtering-ui): fix failing tests

* test(grid-filtering-ui): fix linting erros
rkaraivanov pushed a commit that referenced this issue Nov 26, 2018
@rkaraivanov
fix(calendar): make all class names unique (#3115)
650d61a 
* fix(calendar): make all class names unique

Closes #2287

* Update calendar.component.spec.ts

* test(grid-filtering-ui): fix failing tests

* test(grid-filtering-ui): fix linting errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@StefanIvanov StefanIvanov

@simeonoff simeonoff

Labels
❓ question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@StefanIvanov @simeonoff @ig-robstoffers @desig9stein @SlavUI